Skip to content

[mono] Stop setting time_date_stamp field in MonoImage - #66452

Merged
akoeplinger merged 2 commits into
dotnet:mainfrom
akoeplinger:remove-pefile-timestamp
Mar 10, 2022
Merged

[mono] Stop setting time_date_stamp field in MonoImage#66452
akoeplinger merged 2 commits into
dotnet:mainfrom
akoeplinger:remove-pefile-timestamp

Conversation

@akoeplinger

Copy link
Copy Markdown
Member

We never read that field in the runtime and it was causing unnecessary disk IO during startup (5ms on my iOS device).
It was also never set on Windows already.

We never read that field in the runtime and it was causing unnecessary disk IO during startup (5ms on my iOS device).
It was also never set on Windows already.
@akoeplingerakoeplinger added the tenet-performance Performance related issue label Mar 10, 2022
@ghostghost added the area-VM-meta-mono label Mar 10, 2022
Comment threadsrc/mono/mono/metadata/metadata-internals.h Outdated
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
@akoeplinger
akoeplinger merged commit d282630 into dotnet:mainMar 10, 2022
@akoeplinger
akoeplinger deleted the remove-pefile-timestamp branch March 10, 2022 21:53
@ghostghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-meta-monotenet-performancePerformance related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@akoeplinger@lambdageek