Skip to content

Some small copy propagation changes - #66582

Merged
kunalspathak merged 2 commits into
dotnet:mainfrom
SingleAccretion:Small-Copy-Prop-Improvements
Mar 15, 2022
Merged

Some small copy propagation changes#66582
kunalspathak merged 2 commits into
dotnet:mainfrom
SingleAccretion:Small-Copy-Prop-Improvements

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Mar 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Address #65902 (comment).

Add some asserts now that we don't push all the defs and don't have them implicitly.

No diffs.

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 14, 2022
@ghost

ghost commented Mar 14, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

And add some asserts now that we don't push all the defs and don't have them implicitly.

No diffs are expected.

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@SingleAccretionSingleAccretion changed the title Address https://github.com/dotnet/runtime/pull/65902#discussion_r818153639Some small copy propagation changesMar 14, 2022
@SingleAccretion
SingleAccretion marked this pull request as ready for review March 14, 2022 16:53
@SingleAccretion

SingleAccretion commented Mar 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Will once again assume OSX timeouts are not related.

@dotnet/jit-contrib

@AndyAyersMS

AndyAyersMS commented Mar 15, 2022

Copy link
Copy Markdown
Member

@kunalspathak ptal

@kunalspathak

kunalspathak commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime-coreclr jitstress

@azure-pipelines

azure-pipelinesBot commented Mar 15, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@SingleAccretion

SingleAccretion commented Mar 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Stress failures look like #66601 and #63854.

kunalspathak
kunalspathak approved these changes Mar 15, 2022
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kunalspathak
kunalspathak merged commit 84de128 into dotnet:mainMar 15, 2022
@SingleAccretion
SingleAccretion deleted the Small-Copy-Prop-Improvements branch March 15, 2022 16:15
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@SingleAccretion@radekdoulik
Some small copy propagation changes (dotnet#66582)
5bf9b18
* Add asserts
* Remove the quirk comment, replace with a TODO-CQ
@JulieLeeMSFTJulieLeeMSFT mentioned this pull request Apr 1, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@kunalspathak