Skip to content

Remove superfluous string[] and string from System.IO.Packaging.ContentType - #66764

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:packagingcontenttype
Mar 18, 2022
Merged

Remove superfluous string[] and string from System.IO.Packaging.ContentType#66764
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:packagingcontenttype

Conversation

@stephentoub

@stephentoubstephentoub commented Mar 17, 2022

Copy link
Copy Markdown
Member

Related to dotnet/wpf#6268

@ghost

ghost commented Mar 17, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to dotnet/wpf#6268

Author:stephentoub
Assignees:stephentoub
Labels:

area-System.IO.Compression

Milestone:-

@Tornhoof

Tornhoof commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

Has cha----ter in the comment (end of line)

runtime/src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs

Line 405 in 8513b63

/// 2. If all the characters in the token are either from the remaining allowed cha----ter set.

any special meaning?, otherwise search/replace with character. This kinda looks like some older search/replace gone wrong. There is more than one hit.

@stephentoub

stephentoub commented Mar 17, 2022

Copy link
Copy Markdown
MemberAuthor

any special meaning?

Purely a guess, but I'd speculate someone meant to write "character", instead had a typo and wrote "characeter", and a well-meaning tool decided to remove a potentially sensitive substring, leaving "cha----ter". Feel free to submit a PR to clean it up.

adamsitnik
adamsitnik approved these changes Mar 18, 2022
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @stephentoub

Comment threadsrc/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Comment threadsrc/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Comment threadsrc/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
@stephentoub
stephentoub merged commit 3b2808b into dotnet:mainMar 18, 2022
@stephentoub
stephentoub deleted the packagingcontenttype branch March 18, 2022 11:49
@TornhoofTornhoof mentioned this pull request Mar 18, 2022
Merged
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@stephentoub@radekdoulik
Remove superfluous string[] and string from System.IO.Packaging.Conte…
27daf3b
…ntType (dotnet#66764)
@ghostghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@stephentoubstephentoub

Labels

area-System.IO.Compression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@Tornhoof@adamsitnik@AaronRobinsonMSFT