Try to fix a time-sensitive thread pool test - #66765

Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom
kouvel:TestFix
Closed

Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom
kouvel:TestFix

Conversation

@kouvel

@kouvelkouvel commented Mar 17, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.

Hopefully fixes#66852

@kouvelkouvel added this to the 7.0.0 milestone Mar 17, 2022
@kouvel
kouvel requested a review from mangod9March 17, 2022 15:49
@kouvelkouvel self-assigned this Mar 17, 2022
@kouvelkouvel mentioned this pull request Mar 17, 2022
Closed
@ghost

ghost commented Mar 17, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.

Hopefully fixes #66755

Author:kouvel
Assignees:kouvel
Labels:

area-System.Threading

Milestone:7.0.0

This was referenced Mar 17, 2022
Closed
Closed
@kouvelkouvel mentioned this pull request Mar 18, 2022
Closed
@am11

am11 commented Mar 19, 2022

Copy link
Copy Markdown
Member

If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g.

runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7 in 38af2b8

[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]
(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)

@adamsitnikadamsitnik mentioned this pull request Mar 22, 2022
Merged
@kouvel

kouvel commented Mar 22, 2022

Copy link
Copy Markdown
ContributorAuthor

If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it

Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?

@am11

am11 commented Mar 22, 2022

Copy link
Copy Markdown
Member

I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.

@adamsitnik

adamsitnik commented Mar 22, 2022

Copy link
Copy Markdown
Member

I am not sure but I think on helix, we only execute one test assembly at a time?

Afaik this is true (cc @ericstj who is our ultimate source of truth).

DisableParallelizationPerAssembly

by using it it's ensured that all tests in given assembly are run sequentially.

DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).

@agocke

agocke commented Mar 22, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled

@hoyosjs

hoyosjs commented Mar 22, 2022

Copy link
Copy Markdown
Member

Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.

Koundinya Veluri added 2 commits March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj

ericstj commented Mar 22, 2022

Copy link
Copy Markdown
Member

Afaik this is true (cc @ericstj who is our ultimate source of truth).

Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure

In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:

runtime/eng/testing/tests.targets

Line 104 in 96ef47b

<GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand

The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:

runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303 in d8f8527

<XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
$(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
$(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
$(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
$(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
$(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
$(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
$(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
$(TestBinDir)GC\**\*.XUnitWrapper.dll;
$(TestBinDir)hosting\**\*.XUnitWrapper.dll;
$(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
$(TestBinDir)Loader\**\*.XUnitWrapper.dll;
$(TestBinDir)managed\**\*.XUnitWrapper.dll;
$(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
$(TestBinDir)reflection\**\*.XUnitWrapper.dll;
$(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
$(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll">
<PayloadGroup>PayloadGroup0</PayloadGroup>
</XUnitWrapperGrouping>

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518 in 90ec876

<XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls>

@kouvel

kouvel commented Mar 22, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks all! I'll try disabling parallelization for this test.

@kouvel

kouvel commented Mar 31, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.

@kouvelkouvel closed this Mar 31, 2022
@kouvel
kouvel deleted the TestFix branch March 31, 2022 02:59
@ghostghost locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac

6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Try to fix a time-sensitive thread pool test - #66765
Closed
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Closed
Try to fix a time-sensitive thread pool test#66765
kouvel wants to merge 5 commits into
dotnet:mainfrom 
kouvel:TestFix
Conversation
@kouvel
@kouvelkouvel
commented
Mar 17, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66852
@kouvelkouvel
added this to the 7.0.0 milestone
Mar 17, 2022
@kouvel
kouvel
requested a review
from mangod9March 17, 2022 15:49
@kouvelkouvel
self-assigned this
Mar 17, 2022
@kouvelkouvel
mentioned this pull request
Mar 17, 2022

Closed

@ghost
ghost
commented
Mar 17, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
Issue Details
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes #66755
Author:kouvel
Assignees:kouvel
Labels:
area-System.Threading
Milestone:7.0.0

This was referenced Mar 17, 2022

Closed


Closed

@kouvelkouvel
mentioned this pull request
Mar 18, 2022

Closed

@am11
am11
commented
Mar 19, 2022

Copy link


Copy Markdown

Member
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it, e.g. 
runtime/src/libraries/System.Configuration.ConfigurationManager/tests/AssemblyInfo.cs

Line 7
in
38af2b8
[assembly:CollectionBehavior(DisableTestParallelization=true,MaxParallelThreads=1)]

(requires <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelizationPerAssembly.cs" /> in csproj)
@adamsitnikadamsitnik
mentioned this pull request
Mar 22, 2022
 Merged

@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
If parallelization is the root-cause of failure, there is DisableTestParallelization behavior to disable it
Does that disable parallelization only for this test assembly, or does it also disable parallelization between tests from different assemblies?
@am11
am11
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time? @adamsitnik might know the definite answer.
@adamsitnik
adamsitnik
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
I am not sure but I think on helix, we only execute one test assembly at a time?
Afaik this is true (cc @ericstj who is our ultimate source of truth).
DisableParallelizationPerAssembly
by using it it's ensured that all tests in given assembly are run sequentially.
DisableParallelization runs all other tests in parallel first, and then at the end sequentially tests from types marked with this attribute (this is typically what I am using).
@agocke
agocke
commented
Mar 22, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@kouvel What's the status of this change? Will it be done today? nvm, missed that the test was disabled
@hoyosjs
hoyosjs
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Helix assemblies for libraries do run on a project basis: https://helix.dot.net/api/jobs/f8d1561b-e515-4958-8114-6d2a0900b0de/workitems?api-version=2019-06-17 each one of those runs separately.
Koundinya Veluri
added 2 commits
March 22, 2022 11:12
Koundinya Veluri
Try to fix a time-sensitive thread pool test
b835076
I guess the test may occasionally time out if it's running in parallel with other tests, depending on what those other tests are doing. Subscribed to thread adjustment events to see if progress is being made to extend the timeout.
Hopefully fixes#66755
Koundinya Veluri
Disable test on Mono
55d9665
@ericstj
ericstj
commented
Mar 22, 2022

Copy link


Copy Markdown

Member
Afaik this is true (cc @ericstj who is our ultimate source of truth).
Ha! I'm not the source of truth -- the source is. I just read it. It can change at any time so I go back and re-read it. Sometimes I don't read the source and instead read the test logs if I don't trust my eyeball-debugger. cc @dotnet/runtime-infrastructure
In libraries we don't parallelize at the assembly level. Each test assembly gets launched once and helix only runs one job at a time on the machine. You can examine how that works here:
runtime/eng/testing/tests.targets

Line 104
in
96ef47b
 <GenerateRunScriptRunCommands="@(RunScriptCommands)"

https://github.com/dotnet/runtime/search?q=RunScriptCommand
The coreclr tests are a little different. They intentionally parallelize (and that actually has caused problems). You can see that here:
runtime/src/tests/Common/testgrouping.proj

Lines 284 to 303
in
d8f8527
 <XUnitWrapperGroupingInclude="$(TestBinDir)baseservices\compilerservices\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\exceptions\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\multidimmarray\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\TieredCompilation\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\typeequivalence\*.XUnitWrapper.dll;
 $(TestBinDir)baseservices\varargs\*.XUnitWrapper.dll;
 $(TestBinDir)CoreMangLib\**\*.XUnitWrapper.dll;
 $(TestBinDir)Exceptions\**\*.XUnitWrapper.dll;
 $(TestBinDir)GC\**\*.XUnitWrapper.dll;
 $(TestBinDir)hosting\**\*.XUnitWrapper.dll;
 $(TestBinDir)ilasm\**\*.XUnitWrapper.dll;
 $(TestBinDir)Loader\**\*.XUnitWrapper.dll;
 $(TestBinDir)managed\**\*.XUnitWrapper.dll;
 $(TestBinDir)readytorun\**\*.XUnitWrapper.dll;
 $(TestBinDir)reflection\**\*.XUnitWrapper.dll;
 $(TestBinDir)Regressions\**\*.XUnitWrapper.dll;
 $(TestBinDir)tracing\**\*.XUnitWrapper.dll"
Exclude="$(TestBinDir)Loader\classloader\Loader.classloader.XUnitWrapper.dll"> 
 <PayloadGroup>PayloadGroup0</PayloadGroup> 
 </XUnitWrapperGrouping> 

runtime/src/tests/Common/helixpublishwitharcade.proj

Line 518
in
90ec876
 <XUnitWrapperDlls>$([System.String]::Join(' ', $([System.IO.Directory]::GetFiles(%(FullPath), '*.XUnitWrapper.dll', SearchOption.AllDirectories))).Replace($([MSBuild]::EnsureTrailingSlash(%(FullPath))),''))</XUnitWrapperDlls> 
@kouvel
kouvel
commented
Mar 22, 2022

Copy link


Copy Markdown

ContributorAuthor
Thanks all! I'll try disabling parallelization for this test.
@kouvel
kouvel
commented
Mar 31, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Still failing and appears to not be a parallelization issue. I can repro the issue on the latest macOS, seems to be an issue with GC.GetGCMemoryInfo() reporting that the memory load is >= the memory limit. Considering that it started failing somewhat suddenly, I suspect it has something to do with GC or OS changes. I'll file a separate issue.
@kouvelkouvel
closed this
Mar 31, 2022
@kouvel
kouvel
deleted the

TestFix

branch
March 31, 2022 02:59
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@mangod9mangod9Awaiting requested review from mangod9

Assignees

@kouvelkouvel

Labels

area-System.Threading

Projects


None yet


Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Threadpool test CooperativeBlockingCanCreateThreadsFaster failing on Mac


6 participants

@kouvel@am11@adamsitnik@agocke@hoyosjs@ericstj