Skip to content

JIT: block some struct promotion for OSR - #67131

Merged
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:FixOSRRegression
Mar 25, 2022
Merged

JIT: block some struct promotion for OSR#67131
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:FixOSRRegression

Conversation

@AndyAyersMS

@AndyAyersMSAndyAyersMS commented Mar 25, 2022

Copy link
Copy Markdown
Member

This undoes part of #65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.

Fixes#67078

This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 25, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

This undoes part of #65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.

Author:AndyAyersMS
Assignees:AndyAyersMS
Labels:

area-CodeGen-coreclr

Milestone:-

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

This has a handful of diffs in the aspnet collection. It will also likely have a negative perf impact on microbenchmarks, but I won't know the magnitude of that until after merging and letting the lab get a few days' worth of data.

cc @dotnet/jit-contrib

@AndyAyersMSAndyAyersMS mentioned this pull request Mar 25, 2022
72 tasks
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr libraries-pgo

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Unlikely that the libraries pgo will run cleanly, so I'll have to parse the results.

Not sure why SPMI is failing, looks like infrastructure perhaps?

Invoking: git log --pretty=format:%H aea7c73b6be57845df53880cf95b3f7fa58e477c -20 -- src/coreclr/jit/*
try 1: 3fe2959f3e0c7255a90098946e57e6e7294476b1
Didn't find any collections using https://clrjit2.blob.core.windows.net/jitrollingbuild?restype=container&comp=list&prefix=builds/3fe2959f3e0c7255a90098946e57e6e7294476b1/windows/x64/Checked
Error: [WinError 10054] An existing connection was forcibly closed by the remote host
Traceback (most recent call last):
File "D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py", line 815, in <module>
sys.exit(main(args))
File "D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py", line 797, in main
download_command(coreclr_args)
File "D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py", line 639, in download_command
if len(urls) == 0:
TypeError: object of type 'NoneType' has no len()
D:\a\_work\1\s\src\coreclr\scripts\jitrollingbuild.py failed with 1

am going to retry

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Libraries failure is #66571

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

Libraries PGO tests look to be improved overall.

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

SPMI seems to have passed on rerun but gotten a little confused.

@AndyAyersMS
AndyAyersMS merged commit 6627183 into dotnet:mainMar 25, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.
@ghostghost locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSR stress failure in System.Diagnostics.DiagnosticsSource.Tests

2 participants

@AndyAyersMS@EgorBo