Uh oh!
There was an error while loading. Please reload this page.
JIT: block some struct promotion for OSR - #67131
Conversation
This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis for struct promotion as they only see parts of methods.
ghost
commented
Mar 25, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis undoes part of #65903. OSR methods can't rely solely on their own analysis
|
AndyAyersMS
commented
Mar 25, 2022
This has a handful of diffs in the aspnet collection. It will also likely have a negative perf impact on microbenchmarks, but I won't know the magnitude of that until after merging and letting the lab get a few days' worth of data. cc @dotnet/jit-contrib |
AndyAyersMS
commented
Mar 25, 2022
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndyAyersMS
commented
Mar 25, 2022
Unlikely that the libraries pgo will run cleanly, so I'll have to parse the results. Not sure why SPMI is failing, looks like infrastructure perhaps? am going to retry |
AndyAyersMS
commented
Mar 25, 2022
Libraries failure is #66571 |
AndyAyersMS
commented
Mar 25, 2022
Libraries PGO tests look to be improved overall. |
AndyAyersMS
commented
Mar 25, 2022
SPMI seems to have passed on rerun but gotten a little confused. |
This undoes part of dotnet#65903. OSR methods can't rely solely on their own analysis for struct promotion as they only see parts of methods.
This undoes part of #65903. OSR methods can't rely solely on their own analysis
for struct promotion as they only see parts of methods.
Fixes#67078