Uh oh!
There was an error while loading. Please reload this page.
Mark promoted locals indirectly used by RETURNs DNER - #67358
Closed
SingleAccretion wants to merge 1 commit into
Closed
Mark promoted locals indirectly used by RETURNs DNER#67358SingleAccretion wants to merge 1 commit into
RETURNs DNER#67358SingleAccretion wants to merge 1 commit into
Conversation
Thus forcing dependent promotion on them.
ghost
commented
Mar 30, 2022
Tagging subscribers to this area: @JulieLeeMSFT |
SingleAccretion
commented
Mar 30, 2022
ContributorAuthor
@dotnet/jit-contrib could someone please run the outerloop here to verify this actually fixes #67355? |
EgorBo
commented
Mar 30, 2022
Member
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SingleAccretion
commented
Mar 30, 2022
ContributorAuthor
I have verified that it does not. I will be reverting #66251. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus forcing dependent promotion on them.
Fixes#67346, #67355.
There is an SPMI in CI outage right now due to #66558 (a recollection is needed), local replays with the
FieldInfoworkaround show no diffs (as expected).