Uh oh!
There was an error while loading. Please reload this page.
Enable all StructABI tests in pri-0 - #67362
Merged
Merged
Conversation
ghost
commented
Mar 30, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsStruct-related ABI regression tests are important. This would have (presumably) caught #67355 in normal CI without triggering outerloop
|
BruceForstall
commented
Mar 30, 2022
ContributorAuthor
@dotnet/jit-contrib PTAL |
BruceForstall
commented
Mar 30, 2022
ContributorAuthor
AndyAyersMS
approved these changes
Mar 30, 2022
BruceForstall
commented
Mar 31, 2022
ContributorAuthor
The CI failures are all expected, fixed by #67360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Struct-related ABI regression tests are important. This would have (presumably) caught #67355 in normal CI without triggering outerloop