') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Reenable SocketsHttpHandlerTest_Http3_MsQuic.SendMoreThanStreamLimitRequestsConcurrently_LastWaits test by rzikm · Pull Request #67419 · dotnet/runtime · GitHub
Skip to content

Reenable SocketsHttpHandlerTest_Http3_MsQuic.SendMoreThanStreamLimitRequestsConcurrently_LastWaits test - #67419

Merged
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:55901-HTTP/3-SocketsHttpHandlerTest_Http3_MsQuicSendMoreThanStreamLimitRequestsConcurrently_LastWaitsstreamLimit-10-fails
May 3, 2022
Merged

Reenable SocketsHttpHandlerTest_Http3_MsQuic.SendMoreThanStreamLimitRequestsConcurrently_LastWaits test#67419
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:55901-HTTP/3-SocketsHttpHandlerTest_Http3_MsQuicSendMoreThanStreamLimitRequestsConcurrently_LastWaitsstreamLimit-10-fails

Conversation

@rzikm

@rzikmrzikm commented Apr 1, 2022

Copy link
Copy Markdown
Member

Just check if test passes on CI

@ghostghost assigned rzikmApr 1, 2022
@ghost

ghost commented Apr 1, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Just check if test passes on CI

Author:rzikm
Assignees:rzikm
Labels:

area-System.Net.Http

Milestone:-

@rzikm

rzikm commented Apr 1, 2022

Copy link
Copy Markdown
MemberAuthor

I managed to reproduce this locally, will try to catch a dump to see what is going on

@rzikm

rzikm commented Apr 8, 2022

Copy link
Copy Markdown
MemberAuthor

dump analysis shows that the lastRequestContentStarted task completion source is never set and that server task is "stuck" after disposing of the first stream. Will revisit this after we have proper async dispose of the MsQuicStream

@ghost

ghost commented Apr 22, 2022

Copy link
Copy Markdown

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@rzikm
rzikmforce-pushed the 55901-HTTP/3-SocketsHttpHandlerTest_Http3_MsQuicSendMoreThanStreamLimitRequestsConcurrently_LastWaitsstreamLimit-10-fails branch from 7bbeb6a to b4d4e35CompareApril 27, 2022 11:56
@ghostghost removed the no-recent-activity label Apr 27, 2022
@rzikm
rzikm marked this pull request as ready for review April 27, 2022 16:21
@rzikm

rzikm commented Apr 27, 2022

Copy link
Copy Markdown
MemberAuthor

Does not reproduce anymore after #67859

@rzikm
rzikm requested a review from CarnaViireApril 27, 2022 16:22
CarnaViire
CarnaViire approved these changes May 3, 2022
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's try it. Could you please take a closer look at this test in CI for some time to be sure it wouldn't start failing/hanging?

Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs Outdated
@rzikm@CarnaViire
Update src/libraries/System.Net.Http/tests/FunctionalTests/HttpClient…
badd60b
…HandlerTest.Http3.cs
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
@rzikm

rzikm commented May 3, 2022

Copy link
Copy Markdown
MemberAuthor

I am still monitoring all test failures so if this starts happening again, I will hopefully notice it :)

@rzikm

rzikm commented May 3, 2022

Copy link
Copy Markdown
MemberAuthor

CI Failures are unrelated (LibraryImportGenerator.Unit.Tests)

@rzikm
rzikm merged commit ec28cb3 into dotnet:mainMay 3, 2022
@rzikmrzikm mentioned this pull request May 3, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 2, 2022
@karelzkarelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

@rzikmrzikm

Labels

area-System.Net.Http

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rzikm@CarnaViire@karelz