Skip to content

JIT: Disable cast profiling by default - #67460

Merged
EgorBo merged 1 commit into
dotnet:mainfrom
EgorBo:disable-cast-prof
Apr 2, 2022
Merged

JIT: Disable cast profiling by default#67460
EgorBo merged 1 commit into
dotnet:mainfrom
EgorBo:disable-cast-prof

Conversation

@EgorBo

@EgorBoEgorBo commented Apr 1, 2022

Copy link
Copy Markdown
Member

Accidently left these enabled in #65922

DOTNET_JitProfileCasts is only supposed to be used for mibc, it's too heavy for DynamicPGO
DOTNET_JitConsumeProfileForCasts will be enabled by default once mibc is updated

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 1, 2022
@ghostghost assigned EgorBoApr 1, 2022
@ghost

ghost commented Apr 1, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Accidently left these enabled in #65922

DOTNET_JitProfileCasts is only supposed to be used for mibc, it's to heavy for DynamicPGO
JitConsumeProfileForCasts will be enabled by default once mibc is updated

Author:EgorBo
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@EgorBo
EgorBo requested a review from jakobbotschApril 1, 2022 21:40
@EgorBo
EgorBo merged commit 0c1fbe0 into dotnet:mainApr 2, 2022
@ghostghost locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@jakobbotsch