Uh oh!
There was an error while loading. Please reload this page.
[wasm] EmccCompile: Add support for compiling sequentially - #67483
[wasm] EmccCompile: Add support for compiling sequentially#67483radical wants to merge 6 commits into
Conversation
This adds support for two cases: 1. Compiling an assembly in parallel fails due to getting oomkill'ed. In this case, it will get compiled again but not in parallel with anything else. 2. User specified assemblies that should always be compiled sequentially. This would be useful for cases where some assemblies fail to compile because `emcc` runs out of memory. New: ``` - $(WasmRetrySequentiallyIfNeeded) - Retry assembly compilation to .o files sequentially, if needed. One such case could be if the compiler got killed due to OOM. Defaults to true. - @(WasmAssemblyToAOTSequentially) - Filenames of assemblies to always compile (to .o) sequentially ```
ghost
commented
Apr 2, 2022
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis adds support for two cases:
This would be useful for cases where some assemblies fail to compile New:
|
radical
commented
Apr 2, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
commented
Apr 3, 2022
Not sure that a build system should retry failing commands. Would a setting limiting the amount of parallelism, like make's -j argument work ? |
radical
commented
Apr 4, 2022
Using only I have removed the |
radical
commented
Apr 4, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
commented
Apr 5, 2022
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
commented
Jun 27, 2022
@ankit do you still think this is useful? |
ghost
commented
Aug 2, 2022
This pull request has been automatically marked |
ghost
commented
Dec 29, 2022
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Add support for user specified assemblies that should always be compiled
sequentially. This would be useful for cases where some assemblies fail to compile
because
emccruns out of memory when compiled in parallel with other assemblies.New: