Skip to content

[Group 9] Enable nullable annotations for Microsoft.Extensions.Hosting.Systemd - #67513

Merged
eerhardt merged 3 commits into
dotnet:mainfrom
maxkoshevoi:mk/43605-hosting-systemd
Apr 18, 2022
Merged

[Group 9] Enable nullable annotations for Microsoft.Extensions.Hosting.Systemd#67513
eerhardt merged 3 commits into
dotnet:mainfrom
maxkoshevoi:mk/43605-hosting-systemd

Conversation

@maxkoshevoi

@maxkoshevoimaxkoshevoi commented Apr 3, 2022

Copy link
Copy Markdown
Contributor

Fixes#43605

It's not mentioned in 43605, but it exists, so why not?

@ghostghost added area-Extensions-Hosting community-contribution Indicates that the PR has been added by a community member labels Apr 3, 2022
@ghost

ghost commented Apr 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

It's not mentioned in 43605, but it exists, so why not?

Author:maxkoshevoi
Assignees:-
Labels:

area-Extensions-Hosting

Milestone:-

@eerhardt

Copy link
Copy Markdown
Member

It's not mentioned in 43605, but it exists, so why not?

Thanks for calling this out. I've added it and Hosting.WindowsServices to the list.

@maxkoshevoi
maxkoshevoi marked this pull request as ready for review April 16, 2022 05:38
@maxkoshevoi

Copy link
Copy Markdown
ContributorAuthor

Seems like this needs a suppression file

@eerhardt

Copy link
Copy Markdown
Member

Seems like this needs a suppression file

It was just simpler to use a ! operator here in one place.

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt
eerhardt merged commit 9849af2 into dotnet:mainApr 18, 2022
directhex pushed a commit to directhex/runtime that referenced this pull request Apr 21, 2022
…ng.Systemd` (dotnet#67513)
Fixdotnet#43605
* Annotate
* Fix API compat check by removing MemberNotNullWhen attribute.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-Hostingcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotate Microsoft.Extensions.* assemblies for nullable reference types

3 participants

@maxkoshevoi@eerhardt@maryamariyan