Skip to content

add TaskCreationOptions for Task.Run - #67694

Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed

add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun

Conversation

@isdaniel

@isdanielisdaniel commented Apr 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Support to use passing TaskCreationOptions when we use Task.Run method.

Description

I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.

So this MR supports us to pass TaskCreationOptions when we use Task.Run method.

@ghostghost added area-System.Threading.Tasks community-contribution Indicates that the PR has been added by a community member labels Apr 7, 2022
@ghost

ghost commented Apr 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

Support to use passing TaskCreationOptions when we use Task.Run method.

Description

Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.

I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.

So this MR supports us to pass TaskCreationOptions when we use Task.Run method.

Author:isdaniel
Assignees:-
Labels:

area-System.Threading.Tasks, community-contribution

Milestone:-

@dnfadmin

dnfadmin commented Apr 7, 2022•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@gfoidl

gfoidl commented Apr 7, 2022

Copy link
Copy Markdown
Member

This change would require an API review first.

Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.

@stephentoub

stephentoub commented Apr 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.

Regardless, per the previous comments, I'm closing this. Thanks.

@ghostghost locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
add TaskCreationOptions for Task.Run by isdaniel · Pull Request #67694 · dotnet/runtime · GitHub
Skip to content
add TaskCreationOptions for Task.Run - #67694
Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed
add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Conversation
@isdaniel
@isdanielisdaniel
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
@ghostghost
added

area-System.Threading.Tasks

community-contribution
Indicates that the PR has been added by a community member
labels
Apr 7, 2022
@ghost
ghost
commented
Apr 7, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

See info in area-owners.md if you want to be subscribed.
Issue Details
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
Author:isdaniel
Assignees:-
Labels:
area-System.Threading.Tasks, community-contribution
Milestone:-
@dnfadmin
dnfadmin
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
@gfoidl
gfoidl
commented
Apr 7, 2022

Copy link


Copy Markdown

Member
This change would require an API review first.
Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.
@stephentoub
stephentoub
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.
Regardless, per the previous comments, I'm closing this. Thanks.
@ghostghost
locked as resolved and limited conversation to collaborators
May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add TaskCreationOptions for Task.Run by isdaniel · Pull Request #67694 · dotnet/runtime · GitHub
Skip to content
add TaskCreationOptions for Task.Run - #67694
Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed
add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Conversation
@isdaniel
@isdanielisdaniel
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
@ghostghost
added

area-System.Threading.Tasks

community-contribution
Indicates that the PR has been added by a community member
labels
Apr 7, 2022
@ghost
ghost
commented
Apr 7, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

See info in area-owners.md if you want to be subscribed.
Issue Details
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
Author:isdaniel
Assignees:-
Labels:
area-System.Threading.Tasks, community-contribution
Milestone:-
@dnfadmin
dnfadmin
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
@gfoidl
gfoidl
commented
Apr 7, 2022

Copy link


Copy Markdown

Member
This change would require an API review first.
Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.
@stephentoub
stephentoub
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.
Regardless, per the previous comments, I'm closing this. Thanks.
@ghostghost
locked as resolved and limited conversation to collaborators
May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add TaskCreationOptions for Task.Run by isdaniel · Pull Request #67694 · dotnet/runtime · GitHub
Skip to content
add TaskCreationOptions for Task.Run - #67694
Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed
add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Conversation
@isdaniel
@isdanielisdaniel
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
@ghostghost
added

area-System.Threading.Tasks

community-contribution
Indicates that the PR has been added by a community member
labels
Apr 7, 2022
@ghost
ghost
commented
Apr 7, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

See info in area-owners.md if you want to be subscribed.
Issue Details
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
Author:isdaniel
Assignees:-
Labels:
area-System.Threading.Tasks, community-contribution
Milestone:-
@dnfadmin
dnfadmin
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
@gfoidl
gfoidl
commented
Apr 7, 2022

Copy link


Copy Markdown

Member
This change would require an API review first.
Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.
@stephentoub
stephentoub
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.
Regardless, per the previous comments, I'm closing this. Thanks.
@ghostghost
locked as resolved and limited conversation to collaborators
May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
add TaskCreationOptions for Task.Run by isdaniel · Pull Request #67694 · dotnet/runtime · GitHub
Skip to content
add TaskCreationOptions for Task.Run - #67694
Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed
add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Conversation
@isdaniel
@isdanielisdaniel
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
@ghostghost
added

area-System.Threading.Tasks

community-contribution
Indicates that the PR has been added by a community member
labels
Apr 7, 2022
@ghost
ghost
commented
Apr 7, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

See info in area-owners.md if you want to be subscribed.
Issue Details
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
Author:isdaniel
Assignees:-
Labels:
area-System.Threading.Tasks, community-contribution
Milestone:-
@dnfadmin
dnfadmin
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
@gfoidl
gfoidl
commented
Apr 7, 2022

Copy link


Copy Markdown

Member
This change would require an API review first.
Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.
@stephentoub
stephentoub
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.
Regardless, per the previous comments, I'm closing this. Thanks.
@ghostghost
locked as resolved and limited conversation to collaborators
May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add TaskCreationOptions for Task.Run by isdaniel · Pull Request #67694 · dotnet/runtime · GitHub
Skip to content
add TaskCreationOptions for Task.Run - #67694
Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed
add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Conversation
@isdaniel
@isdanielisdaniel
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
@ghostghost
added

area-System.Threading.Tasks

community-contribution
Indicates that the PR has been added by a community member
labels
Apr 7, 2022
@ghost
ghost
commented
Apr 7, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

See info in area-owners.md if you want to be subscribed.
Issue Details
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
Author:isdaniel
Assignees:-
Labels:
area-System.Threading.Tasks, community-contribution
Milestone:-
@dnfadmin
dnfadmin
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
@gfoidl
gfoidl
commented
Apr 7, 2022

Copy link


Copy Markdown

Member
This change would require an API review first.
Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.
@stephentoub
stephentoub
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.
Regardless, per the previous comments, I'm closing this. Thanks.
@ghostghost
locked as resolved and limited conversation to collaborators
May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
add TaskCreationOptions for Task.Run by isdaniel · Pull Request #67694 · dotnet/runtime · GitHub
Skip to content
add TaskCreationOptions for Task.Run - #67694
Closed
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Closed
add TaskCreationOptions for Task.Run#67694
isdaniel wants to merge 2 commits into
dotnet:mainfrom 
isdaniel:enhancement/add-TaskCreationOptions-for-TaskRun
Conversation
@isdaniel
@isdanielisdaniel
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
@ghostghost
added

area-System.Threading.Tasks

community-contribution
Indicates that the PR has been added by a community member
labels
Apr 7, 2022
@ghost
ghost
commented
Apr 7, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-threading-tasks

See info in area-owners.md if you want to be subscribed.
Issue Details
Support to use passing TaskCreationOptions when we use Task.Run method.
Description
Add an extension method that supports users can use DI Container objects setting to create AWSOptions object.
I know there is another method Task.Factory.StartNew(Action action, TaskCreationOptions creationOptions) but we usually use Task.Run method.
So this MR supports us to pass TaskCreationOptions when we use Task.Run method.
Author:isdaniel
Assignees:-
Labels:
area-System.Threading.Tasks, community-contribution
Milestone:-
@dnfadmin
dnfadmin
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
@gfoidl
gfoidl
commented
Apr 7, 2022

Copy link


Copy Markdown

Member
This change would require an API review first.
Also the ways it's implemented now is a breaking change, as a new parameter is added to an existing method.
@stephentoub
stephentoub
commented
Apr 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
In addition to what @gfoidl stated, I don't see us adding this (though feel free to open an issue to discuss). Task.Run was added as a shortcut for StartNew for the most common usage, which TaskCreationOptions isn't.
Regardless, per the previous comments, I'm closing this. Thanks.
@ghostghost
locked as resolved and limited conversation to collaborators
May 9, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels

area-System.Threading.Taskscommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@isdaniel@dnfadmin@gfoidl@stephentoub@DD-6677