Uh oh!
There was an error while loading. Please reload this page.
Add support for storing method handle histograms in profiles - #67919
Conversation
Allow method handle histograms in .mibc files and in the PGO text format. Contributes to dotnet#44610.
ec36d86 to
26ad0a8Compare
AndyAyersMS
left a comment
There was a problem hiding this comment.
Jit and SPMI changes look good.
WIll defer to David or Michal for the remainder of the changes.
BruceForstall
commented
Apr 14, 2022
Do you need to change the JIT-EE GUID? |
jakobbotsch
commented
Apr 14, 2022
I have some follow-up changes that will actually start producing and using the new kind of PGO data. I think we can delay updating the JIT-EE GUID to that as just adding new PGO schema kinds should be binary compatible (and my future changes will probably also need another JIT-EE GUID update). |
davidwrighton
commented
Apr 15, 2022
@jakobbotsch Yes, this requires a bump in the R2R minor version. |
davidwrighton
commented
Apr 15, 2022
@jakobbotsch Have you verified that with these changes the dotnet-pgo tool continues to work with .NET 6 runtimes? |
jakobbotsch
commented
Apr 15, 2022
Is it ok to wait until future changes that actually start producing and consuming these? At that point I will add something similar to
Yes, it produced a .mibc with the same hash as dotnet-pgo from current main in my test. |
davidwrighton
commented
Apr 16, 2022
When in doubt, bump the version. If there is no chance that new data could be produced, you don't need to, but bumping the R2R version is pretty cheap, and doesn't come with significant costs as old R2R code should not be broken. |
jakobbotsch
commented
Apr 18, 2022
@davidwrighton I've bumped the R2R minor version and also the JIT-EE GUID to be safe, please take another look. |
jakobbotsch
commented
Apr 25, 2022
ping @davidwrighton, anything else you think I should do here? |
AndyAyersMS
left a comment
There was a problem hiding this comment.
Just looked at JIT / SPMI in depth.
jakobbotsch
commented
May 2, 2022
Ping @davidwrighton, my follow-up depends on this one. |
Allow method handle histograms in .mibc files and in the PGO text format.
Contributes to #44610.
@davidwrighton would this in theory need a R2R version bump? I suppose we can wait with such a bump until we actually start producing profiles with this data (at which point we should also add an equivalent of
GetLikelyClass)?cc @dotnet/jit-contrib