Skip to content

Reduce r2r-extra GC stress level to 0xC per #68060 - #68062

Merged
trylek merged 1 commit into
dotnet:mainfrom
trylek:ReduceR2RGCStressLevel
Apr 15, 2022
Merged

Reduce r2r-extra GC stress level to 0xC per #68060#68062
trylek merged 1 commit into
dotnet:mainfrom
trylek:ReduceR2RGCStressLevel

Conversation

@trylek

Copy link
Copy Markdown
Member

The change #65597 switching over JIT/Methodical tests to use merged wrappers has already
received extensive testing most of which works fine with the exception of r2r-extra runs. According
to my investigation it looks like the GCStress mode 0xF has a bug that got uncovered by the larger
merged test - in some cases the finalizer queue can end up in an infinite loop as the finalizations
keep adding more stuff on the finalizer queue. To prevent additional delays in merging in the
JIT/Methodical test merge I propose temporarily downgrading the GC stress level for these tests
to 0xC per Bruce's suggestion. I expect us to revert this change once the primary bug has been fixed.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Apr 14, 2022
@ghostghost assigned trylekApr 14, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

The change #65597 switching over JIT/Methodical tests to use merged wrappers has already
received extensive testing most of which works fine with the exception of r2r-extra runs. According
to my investigation it looks like the GCStress mode 0xF has a bug that got uncovered by the larger
merged test - in some cases the finalizer queue can end up in an infinite loop as the finalizations
keep adding more stuff on the finalizer queue. To prevent additional delays in merging in the
JIT/Methodical test merge I propose temporarily downgrading the GC stress level for these tests
to 0xC per Bruce's suggestion. I expect us to revert this change once the primary bug has been fixed.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@trylek
trylek merged commit 81339fc into dotnet:mainApr 15, 2022
@trylek
trylek deleted the ReduceR2RGCStressLevel branch April 15, 2022 09:38
@ghostghost locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@BruceForstall