Skip to content

Delete unmanaged AssemblyName parser - #68737

Merged
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:assemblyname-parser
May 3, 2022
Merged

Delete unmanaged AssemblyName parser #68737
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:assemblyname-parser

Conversation

@jkotas

@jkotasjkotas commented Apr 30, 2022

Copy link
Copy Markdown
Member

Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib

@ghostghost assigned jkotasApr 30, 2022
@ghostghost added the area-AssemblyLoader-coreclr only use for closed issues label Apr 30, 2022
@ghost

ghost commented Apr 30, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib

Author:jkotas
Assignees:jkotas
Labels:

area-AssemblyLoader-coreclr

Milestone:-

@jkotasjkotas added NO-REVIEW Experimental/testing PR, do NOT review it and removed area-AssemblyLoader-coreclr only use for closed issues labels Apr 30, 2022
@jkotas

jkotas commented Apr 30, 2022

Copy link
Copy Markdown
MemberAuthor

Depends on #68735

@jkotasjkotas added the area-AssemblyLoader-coreclr only use for closed issues label Apr 30, 2022
@ghost

ghost commented Apr 30, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib

Author:jkotas
Assignees:jkotas
Labels:

NO-REVIEW, area-AssemblyLoader-coreclr

Milestone:-

@jkotas
jkotasforce-pushed the assemblyname-parser branch from 244f71a to 1c4c121CompareMay 1, 2022 14:42
@jkotasjkotas removed the NO-REVIEW Experimental/testing PR, do NOT review it label May 1, 2022
@jkotas
jkotas marked this pull request as ready for review May 1, 2022 14:43
@jkotas
jkotas requested review from VSadov and removed request for MichalStrehovskyMay 1, 2022 14:43
@jkotas
Delete unmanaged AssemblyName parser
2b3e202
Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib
@jkotas
jkotasforce-pushed the assemblyname-parser branch from 1c4c121 to 2b3e202CompareMay 1, 2022 14:47
am11
am11 reviewed May 1, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyNameParser.cs Outdated
VSadov
VSadov reviewed May 2, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyNameParser.cs Outdated
VSadov
VSadov reviewed May 2, 2022
View reviewed changes
Comment threadsrc/coreclr/binder/inc/assemblyidentitycache.hpp
VSadov
VSadov approved these changes May 2, 2022
View reviewed changes

@VSadovVSadov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@jkotas
jkotas merged commit 6d0bcc4 into dotnet:mainMay 3, 2022
@jkotas
jkotas deleted the assemblyname-parser branch May 3, 2022 03:35
@ghostghost locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VSadovVSadovVSadov approved these changes
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkotasjkotas

Labels

area-AssemblyLoader-coreclronly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@am11@VSadov