Skip to content

GetTotalPauseDuration implementation - #68835

Merged
cshung merged 7 commits into
dotnet:mainfrom
cshung:public/public-pause-time
May 20, 2022
Merged

GetTotalPauseDuration implementation#68835
cshung merged 7 commits into
dotnet:mainfrom
cshung:public/public-pause-time

Conversation

@cshung

@cshungcshung commented May 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#66036

  • Mono implementation - we will probably merge before that is done.
  • Organize the EE -> GC interfaces such that it is version resilience.
  • Testing
  • API Documentation

@ghost

ghost commented May 3, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented May 3, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned cshungMay 3, 2022
@cshung
cshungforce-pushed the public/public-pause-time branch from b98898f to a08fe86CompareMay 3, 2022 20:45
MichalStrehovsky
MichalStrehovsky reviewed May 3, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Test.CoreLib/src/System/Runtime/RuntimeImports.cs Outdated
@ghost

ghost commented May 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66036

  • Mono implementation - we will probably merge before that is done.
  • Organize the EE -> GC interfaces such that it is version resilience.
  • Testing
  • API Documentation
Author:cshung
Assignees:cshung
Labels:

area-GC-coreclr, new-api-needs-documentation

Milestone:-

@marek-safar
marek-safar requested a review from BrzVladMay 4, 2022 08:40
@cshung
cshungforce-pushed the public/public-pause-time branch from 73222f9 to 2783560CompareMay 4, 2022 16:41
Maoni0
Maoni0 reviewed May 5, 2022
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.h Outdated
Maoni0
Maoni0 reviewed May 5, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/comutilnative.cpp Outdated
Maoni0
Maoni0 reviewed May 5, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/comutilnative.h Outdated
@cshung
cshungforce-pushed the public/public-pause-time branch from 2783560 to 7233dffCompareMay 9, 2022 19:36
@cshungcshung changed the title [WIP] GetTotalPauseDuration implementationGetTotalPauseDuration implementationMay 12, 2022
@Maoni0Maoni0 mentioned this pull request May 13, 2022
Closed
Maoni0
Maoni0 reviewed May 14, 2022
View reviewed changes
Comment threadsrc/tests/GC/API/GC/GetTotalPauseDuration.cs
@cshung
cshung merged commit f1efc5c into dotnet:mainMay 20, 2022
@cshung
cshung deleted the public/public-pause-time branch May 20, 2022 21:09
@ghostghost locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
@Maoni0Maoni0Maoni0 approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@BrzVladBrzVladAwaiting requested review from BrzVlad

Assignees

@cshungcshung

Labels

area-GC-coreclrnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Exposing the total paused duration in GC.

3 participants

@cshung@Maoni0@MichalStrehovsky