Uh oh!
There was an error while loading. Please reload this page.
[MONO] Factor marshal-lightweight out of marshal-ilgen - #69208
Merged
Conversation
naricc
commented
May 16, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
naricc
commented
May 16, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
naricc
commented
May 21, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
naricc
commented
May 21, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
naricc
commented
May 23, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
|
No pipelines are associated with this pull request. |
nariccforce-pushed
the
naricc/marshal-lightweight
branch
from
May 23, 2022 18:25
f41c962 to
2305147Comparenaricc
commented
May 23, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
|
No pipelines are associated with this pull request. |
naricc
commented
May 24, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
naricc
commented
May 24, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 10 commits
May 25, 2022 16:15
nariccforce-pushed
the
naricc/marshal-lightweight
branch
from
May 25, 2022 20:24
2305147 to
344aa0bComparenaricc
commented
May 25, 2022
ContributorAuthor
/azp run runtime-extra-platforms |
naricc
commented
May 25, 2022
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
ContributorAuthor
naricc
marked this pull request as ready for review
May 26, 2022 16:13
naricc
requested review from
lambdageek, marek-safar, thaystg and vargaz
as code ownersMay 26, 2022 16:13
ContributorAuthor
@lambdageek@vargaz I believe this is ready for review. The remaining test failures seem to be unrelated issues. The tail call one seems to be this: #69850 |
naricc
commented
May 26, 2022
ContributorAuthor
@lateralusX Once this merges your PR should be good to go in (this one: #69236) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR breaks marshal-ilgen into two; marshal-ilgen and marshal-lightweight. The eventually goal of this is to move code not needed in the new marshaling mode to a component to save size. marshal-lightweight will remain in the runtime, and marshal-ilgen will go into the component. When complete, this will save approximately 100 Kb in the runtime.
This change only moves functions, with out breaking them up or re-organizing them internally. Future changes will refactor the methods themselves, with smaller versions in marshal-lightweight. However, this change gets some immediate savings with relatively minimal work.
Contributes to: #61685