Skip to content

[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 16 commits into from
Jun 6, 2022
Merged

[Android] Fix app crash when using non-native HttpClientHandler #69565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
df35e0c
Add test
simonrozsival May 19, 2022
2c64835
Avoid null reference exception
simonrozsival May 19, 2022
edfce3e
Add missing nullable variable annotations
simonrozsival May 20, 2022
ab4555f
Update GetRemoteCertificate method nullability annotations
simonrozsival May 20, 2022
a680326
Fix compilation error
simonrozsival May 20, 2022
8f3ac3c
Remove test
simonrozsival May 20, 2022
a4f70da
Enable System.Net.Http functional tests on Android
simonrozsival May 25, 2022
4f43fb1
Disable tests which test unsupported code paths
simonrozsival May 25, 2022
493f94b
Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…
simonrozsival May 25, 2022
77942c0
Fix accessing the underlying handler in tests
simonrozsival May 25, 2022
5a39ba6
Disable failing tests
simonrozsival May 26, 2022
3c676b5
Skip tests that do not work on Android
simonrozsival May 26, 2022
48c9f02
TMP: include android tests in outerloop-mono
simonrozsival May 26, 2022
2a78426
Change test attributes
simonrozsival May 27, 2022
938e026
Simplify null check
simonrozsival May 27, 2022
02b21b8
Fix invalid cast
simonrozsival May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/pipelines/libraries/outerloop-mono.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
- Linux_x64
- Linux_musl_x64
- OSX_x64
- Android_arm64
jobParameters:
testScope: outerloop
nameSuffix: AllSubsets_Mono
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
[InlineData(SslProtocols.None, false)]
[InlineData(SslProtocols.None, true)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
{
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
[OuterLoop]
[ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
[MemberData(nameof(InvalidCertificateServers))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
{
using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
4 changes: 4 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
[InlineData(false, CancellationMode.Token)]
[InlineData(true, CancellationMode.Token)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
{
if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

[Theory]
[MemberData(nameof(OneBoolAndCancellationMode))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
{
if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
[Theory]
[MemberData(nameof(ThreeBools))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
{
if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
[InlineData(CancellationMode.CancelPendingRequests, true)]
[InlineData(CancellationMode.DisposeHttpClient, true)]
[SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
[InlineData(1, true)]
[InlineData(2, true)]
[InlineData(3, false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
{
var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
[Theory]
[InlineData(6, false)]
[InlineData(3, true)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
int numberOfRequests,
bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down
18 changes: 18 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
{
await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
[Theory]
[MemberData(nameof(CookieNamesValuesAndUseCookies))]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
{
await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
{
var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
{
await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
{
await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
{
await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
{
await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
{
if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
[Theory]
[MemberData(nameof(CookieNamesValuesAndUseCookies))]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
{
await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
{
await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
// ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
{
await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
// ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
{
await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
// ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_Redirect_CookiesArePreserved()
{
if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
{
const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
{
await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
{
await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
{
if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
{
if (UseVersion == HttpVersion30)
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task ProxyTunnelRequest_GetAsync_Success()
{
if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
{
if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
{
if (IsWinHttpHandler)
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
[OuterLoop("Uses external servers")]
[Theory]
[MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
{
const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
{
using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

[Theory]
[MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
{
int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
{
using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[Android] Fix app crash when using non-native HttpClientHandler by simonrozsival · Pull Request #69565 · dotnet/runtime · GitHub
Skip to content
[Android] Fix app crash when using non-native HttpClientHandler#69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

simonrozsival
merged 16 commits into

from

Jun 6, 2022
 Merged


[Android] Fix app crash when using non-native HttpClientHandler
#69565
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
df35e0c

Add test


simonrozsival May 19, 2022
2c64835

Avoid null reference exception


simonrozsival May 19, 2022
edfce3e

Add missing nullable variable annotations


simonrozsival May 20, 2022
ab4555f

Update GetRemoteCertificate method nullability annotations


simonrozsival May 20, 2022
a680326

Fix compilation error


simonrozsival May 20, 2022
8f3ac3c

Remove test


simonrozsival May 20, 2022
a4f70da

Enable System.Net.Http functional tests on Android


simonrozsival May 25, 2022
4f43fb1

Disable tests which test unsupported code paths


simonrozsival May 25, 2022
493f94b

Merge branch 'main' of https://github.com/dotnet/runtime into fix-and…


simonrozsival May 25, 2022
77942c0

Fix accessing the underlying handler in tests


simonrozsival May 25, 2022
5a39ba6

Disable failing tests


simonrozsival May 26, 2022
3c676b5

Skip tests that do not work on Android


simonrozsival May 26, 2022
48c9f02

TMP: include android tests in outerloop-mono


simonrozsival May 26, 2022
2a78426

Change test attributes


simonrozsival May 27, 2022
938e026

Simplify null check


simonrozsival May 27, 2022
02b21b8

Fix invalid cast


simonrozsival May 27, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
eng/pipelines/libraries/outerloop-mono.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,7 @@ jobs:
 - Linux_x64
 - Linux_musl_x64
 - OSX_x64
 - Android_arm64
 jobParameters:
 testScope: outerloop
 nameSuffix: AllSubsets_Mono
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@ public void SingletonReturnsTrue()
#pragma warning restore SYSLIB0039
 [InlineData(SslProtocols.None, false)]
 [InlineData(SslProtocols.None, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task SetDelegate_ConnectionSucceeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
Expand DownExpand Up@@ -98,6 +99,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [OuterLoop]
 [ConditionalTheory(nameof(ClientSupportsDHECipherSuites))]
 [MemberData(nameof(InvalidCertificateServers))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task InvalidCertificateServers_CertificateValidationDisabled_Succeeds(string url)
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

4 changes: 4 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ public HttpClientHandler_Cancellation_Test(ITestOutputHelper output) : base(outp
 [InlineData(false, CancellationMode.Token)]
 [InlineData(true, CancellationMode.Token)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36634", TestPlatforms.Browser)] // out of memory
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task PostAsync_CancelDuringRequestContentSend_TaskCanceledQuickly(bool chunkedTransfer, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && chunkedTransfer)
Expand DownExpand Up@@ -87,6 +88,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>

 [Theory]
 [MemberData(nameof(OneBoolAndCancellationMode))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseHeadersReceived_TaskCanceledQuickly(bool connectionClose, CancellationMode mode)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && connectionClose)
Expand DownExpand Up@@ -207,6 +209,7 @@ await ValidateClientCancellationAsync(async () =>
 [Theory]
 [MemberData(nameof(ThreeBools))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/65429", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly(bool chunkedTransfer, bool connectionClose, bool readOrCopyToAsync)
 {
 if (LoopbackServerFactory.Version >= HttpVersion20.Value && (chunkedTransfer || connectionClose))
Expand DownExpand Up@@ -290,6 +293,7 @@ await ValidateClientCancellationAsync(async () =>
 [InlineData(CancellationMode.CancelPendingRequests, true)]
 [InlineData(CancellationMode.DisposeHttpClient, true)]
 [SkipOnPlatform(TestPlatforms.Browser, "Browser doesn't have blocking synchronous Stream.ReadByte and so it waits for whole body")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream(CancellationMode mode, bool copyToAsync)
 {
 if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ClientCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,7 @@ private HttpClient CreateHttpClientWithCert(X509Certificate2 cert)
 [InlineData(1, true)]
 [InlineData(2, true)]
 [InlineData(3, false)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateOnlySentWhenValid_Success(int certIndex, bool serverExpectsClientCertificate)
 {
 var options = new LoopbackServer.Options { UseSsl = true };
Expand DownExpand Up@@ -129,6 +130,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
 [Theory]
 [InlineData(6, false)]
 [InlineData(3, true)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task Manual_CertificateSentMatchesCertificateReceived_Success(
 int numberOfRequests,
 bool reuseClient) // validate behavior with and without connection pooling, which impacts client cert usage
Expand Down

18 changes: 18 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
 private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -64,6 +65,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainer_CookieSent(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -94,6 +96,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerMultipleCookies_CookiesSent()
 {
 var cookies = new Cookie[]
Expand DownExpand Up@@ -128,6 +131,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddCookieHeader_CookieHeaderSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand All@@ -149,6 +153,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AddMultipleCookieHeaders_CookiesSent()
 {
 await LoopbackServerFactory.CreateClientAndServerAsync(
Expand DownExpand Up@@ -218,6 +223,7 @@ private string GetCookieValue(HttpRequestData request)

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndCookieHeader_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -246,6 +252,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_SetCookieContainerAndMultipleCookieHeaders_BothCookiesSent()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -286,6 +293,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_SetCookieContainer_CorrectCookiesSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -333,6 +341,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>
 [Theory]
 [MemberData(nameof(CookieNamesValuesAndUseCookies))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieAdded(string cookieName, string cookieValue, bool useCookies)
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -365,6 +374,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveMultipleSetCookieHeaders_CookieAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -405,6 +415,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoPathDefined_CookieAddedWithDefaultPath()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -435,6 +446,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_CookiePathDoesNotMatchRequestPath_CookieAccepted()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
Expand DownExpand Up@@ -467,6 +479,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, serverUrl) =>
 // ConditionalFact: CookieContainer does not follow RFC6265 on .NET Framework, therefore the (WinHttpHandler) test is expected to fail
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotNetFramework))]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_Redirect_CookiesArePreserved()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -516,6 +529,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async serverUrl =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieUpdated()
 {
 const string newCookieValue = "789";
Expand DownExpand Up@@ -544,6 +558,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveSetCookieHeader_CookieRemoved()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand All@@ -568,6 +583,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_ReceiveInvalidSetCookieHeader_ValidCookiesAdded()
 {
 await LoopbackServerFactory.CreateServerAsync(async (server, url) =>
Expand DownExpand Up@@ -603,6 +619,7 @@ await LoopbackServerFactory.CreateServerAsync(async (server, url) =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithRedirect_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand DownExpand Up@@ -663,6 +680,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async url =>

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser, "CookieContainer is not supported on Browser")]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsyncWithBasicAuth_ReceiveSetCookie_CookieSent()
 {
 if (UseVersion == HttpVersion30)
Expand Down

3 changes: 3 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Proxy.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -322,6 +322,7 @@ public async Task Proxy_SslProxyUnsupported_Throws()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_GetAsync_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -358,6 +359,7 @@ await LoopbackServer.CreateServerAsync(async (server, uri) =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_MaxConnectionsSetButDoesNotApplyToProxyConnect_Success()
 {
 if (IsWinHttpHandler)
Expand DownExpand Up@@ -415,6 +417,7 @@ await server2.AcceptConnectionAsync(async connection2 =>
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task ProxyTunnelRequest_OriginServerSendsProxyAuthChallenge_NoProxyAuthPerformed()
 {
 if (IsWinHttpHandler)
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -282,6 +282,7 @@ private async Task UseCallback_BadCertificate_ExpectedPolicyErrors_Helper(string
 [OuterLoop("Uses external servers")]
 [Theory]
 [MemberData(nameof(CertificateValidationServersAndExpectedPolicies))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, SslPolicyErrors expectedErrors)
 {
 const int SEC_E_BUFFER_TOO_SMALL = unchecked((int)0x80090321);
Expand All@@ -305,6 +306,7 @@ public async Task UseCallback_BadCertificate_ExpectedPolicyErrors(string url, Ss
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task UseCallback_SelfSignedCertificate_ExpectedPolicyErrors()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -101,6 +101,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa

 [Theory]
 [MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
 {
 int count = 0;
Expand DownExpand Up@@ -242,6 +243,7 @@ public async Task GetAsync_UnsupportedSSLVersion_Throws(SslProtocols sslProtocol
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/69870", TestPlatforms.Android)]
 public async Task GetAsync_NoSpecifiedProtocol_DefaultsToTls12()
 {
 using (HttpClientHandler handler = CreateHttpClientHandler())
Expand Down
Loading