Skip to content

[LoongArch64] enable the promote feature. - #69840

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
shushanhf:main_promote
May 27, 2022
Merged

[LoongArch64] enable the promote feature.#69840
BruceForstall merged 1 commit into
dotnet:mainfrom
shushanhf:main_promote

Conversation

@shushanhf

@shushanhfshushanhf commented May 26, 2022

Copy link
Copy Markdown
Contributor

Enable the promote feature for LoongArch64.

This PR is part of the issue #69705

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 26, 2022
@ghost

ghost commented May 26, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Enable the promote feature for LoongArch64.

This PR is part of the issue #69705

Author:shushanhf
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@shushanhf

shushanhf commented May 26, 2022

Copy link
Copy Markdown
ContributorAuthor

All the failed tests are about Send to Helix.

Hi, @BruceForstall
Could you please review this PR ?

@BruceForstall
BruceForstall self-requested a review May 26, 2022 18:08
BruceForstall
BruceForstall approved these changes May 26, 2022
View reviewed changes

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Glad to see you enabling this!

I requested rerun of the failing tests and will merge after they complete successfully: there was a general infrastructure failure that should now be fixed.

@BruceForstall

BruceForstall commented May 26, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented May 26, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall

BruceForstall commented May 27, 2022

Copy link
Copy Markdown
Contributor

Looks like the testing hit a new infra problem described here: #69878 (comment)

We'll have to wait for that to be resolved before rerunning testing.

@shushanhf

shushanhf commented May 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Looks like the testing hit a new infra problem described here: #69878 (comment)

We'll have to wait for that to be resolved before rerunning testing.

Yes, you are right.
Thanks very much for your review.

@BruceForstall

BruceForstall commented May 27, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented May 27, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
BruceForstall merged commit 2a66135 into dotnet:mainMay 27, 2022
@shushanhf
shushanhf deleted the main_promote branch May 28, 2022 03:13
@ghostghost locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-loongarch64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shushanhf@BruceForstall@teo-tsirpanis