Skip to content

JIT: allow pinvoke calli helper in TreatAsShouldHaveRetBufArg - #69927

Merged
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:Fix69612
May 28, 2022
Merged

JIT: allow pinvoke calli helper in TreatAsShouldHaveRetBufArg#69927
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:Fix69612

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

If we have multiple cold pinvokes in return positions that return
structs by value and we are merging returns, we will end up querying
these calls post-morph, and may see them using CORINFO_HELP_PINVOKE_CALLI.

Fixes#69612.

If we have multiple cold pinvokes in return positions that return
structs by value and we are merging returns, we will end up querying
these calls post-morph, and may see them using CORINFO_HELP_PINVOKE_CALLI.
Fixesdotnet#69612.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

If we have multiple cold pinvokes in return positions that return
structs by value and we are merging returns, we will end up querying
these calls post-morph, and may see them using CORINFO_HELP_PINVOKE_CALLI.

Fixes #69612.

Author:AndyAyersMS
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

3 failures, all unrelated.

Assert failure(PID 24 [0x00000018], Thread: 45 [0x002d]): RawGetMethodTable()
File: /__w/1/s/src/coreclr/gc/gc.cpp Line: 4453
Image: /root/helix/work/correlation/dotnet

Similar open issue #68511

@AndyAyersMS
AndyAyersMS merged commit 9a185a7 into dotnet:mainMay 28, 2022
@ghostghost locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected JIT helper in TreatAsHasRetBufArg

2 participants

@AndyAyersMS@jakobbotsch