Skip to content

Use the signature's struct handle for making outgoing arg copies - #69971

Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom
SingleAccretion:Use-SigClass-In-fgMorphArgs
May 30, 2022
Merged

Use the signature's struct handle for making outgoing arg copies#69971
jakobbotsch merged 2 commits into
dotnet:mainfrom
SingleAccretion:Use-SigClass-In-fgMorphArgs

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented May 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

No diffs as expected.

Fixes#69965.

@SingleAccretion
Do not depend on class handle in "fgMorphArgs"
1b5ed32
Use the signature's handle when making an outgoing arg copy.
@SingleAccretion
Add a test
10ca1ef
@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 29, 2022
@ghost

ghost commented May 29, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@SingleAccretionSingleAccretion changed the title Use the signature struct handle for making outgoing arg copiesUse the signature's struct handle for making outgoing arg copiesMay 29, 2022
@jakobbotsch

jakobbotsch commented May 29, 2022

Copy link
Copy Markdown
Member

Nice, that's one follow-up to #68748 I can cross off my todo-list :-)

@SingleAccretion
SingleAccretion marked this pull request as ready for review May 29, 2022 23:00
jakobbotsch
jakobbotsch approved these changes May 30, 2022
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakobbotsch
jakobbotsch merged commit 486b4d1 into dotnet:mainMay 30, 2022
@SingleAccretion
SingleAccretion deleted the Use-SigClass-In-fgMorphArgs branch May 30, 2022 10:47
@SingleAccretionSingleAccretion mentioned this pull request May 30, 2022
Merged
@tannergoodingtannergooding mentioned this pull request May 31, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

impNormStructVal's OBJ(ADDR(LCL_VAR)) wrapping logic can be too permissive

2 participants

@SingleAccretion@jakobbotsch