Move TypeReference.ToObject to managed (CoreCLR) by Sergio0694 · Pull Request #70055 · dotnet/runtime

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

Sergio0694 · 2022-05-31T21:29:50Z

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	PR	1.944 ns	0.0268 ns	0.0250 ns	0.48
ToObject_String	main	4.087 ns	0.0571 ns	0.0534 ns	1.00

ToObject_Int	PR	41.241 ns	0.2446 ns	0.2042 ns	0.93
ToObject_Int	main	44.195 ns	0.4417 ns	0.3916 ns	1.00

ToObject_FnPointer	PR	43.501 ns	0.3535 ns	0.3133 ns	0.92
ToObject_FnPointer	main	47.152 ns	0.5428 ns	0.5077 ns	1.00

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicunsafeclassTypedReferenceBenchmark{publicstringtext="Hello world";publicintnumber=42;publicdelegate*<int,float,string>pointer=(delegate*<int,float,string>)(void*)(nuint)0xDEADBEEF;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_FnPointer(){returnTypedReference.ToObject(__makeref(pointer));}}

ghost · 2022-05-31T21:29:57Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Overview

This PR moves TypedReference.ToObject to managed in CoreCLR.
I've only added an FCall to handle a slow path that's only ever taken when T is a function pointer.
This is to avoid having to port a whole lot of additional VM code to C# as well.
All other paths, both for reference types and value types (using the new RuntimeHelpers.Box API) are managed now.

API additions (CoreCLR-only)

namespaceSystem{publicunsafestructRuntimeTypeHandle{[MethodImpl(MethodImplOptions.InternalCall)]internalstaticexternunsafeMethodTable*GetElementTypeMethodTable(CorElementTypeelementType);}}namespaceSystem.Runtime.CompilerServices{internalunsafestructTypeHandle{publicboolIsNull{get;}publicTypeDesc*AsTypeDesc();publicMethodTable*GetMethodTable();}internalunsafestructTypeDesc{privatereadonlyuintTypeAndFlags;publicMethodTable*GetMethodTable();publicCorElementTypeGetInternalCorElementType();}internalunsafestructParamTypeDesc{publicreadonlyuintTypeAndFlags;publicreadonlyMethodTable*m_TemplateMT;publicreadonlyTypeHandlem_Arg;publicreadonlyvoid*m_hExposedClassObject;publicMethodTable*GetTemplateMethodTableInternal();}}

Benchmarks

Method	Branch	Mean	Error	StdDev	Ratio
ToObject_String	main	3.8621 ns	0.1293 ns	0.1770 ns	1.00
ToObject_String	PR	0.9941 ns	0.0115 ns	0.0107 ns	0.25

ToObject_Int	main	44.6062 ns	0.2902 ns	0.4432 ns	1.00
ToObject_Int	PR	41.7305 ns	0.4657 ns	0.3889 ns	0.94

Benchmark code (click to expand):

usingSystem.Reflection;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(Assembly.GetExecutingAssembly()).Run(args);[DisassemblyDiagnoser][GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]publicclassArrayGetValueBenchmark{privatestringtext="Hello world";privateintnumber=42;[Benchmark][BenchmarkCategory("REF_TYPE")]publicobject?ToObject_String(){returnTypedReference.ToObject(__makeref(text));}[Benchmark][BenchmarkCategory("VALUE_TYPE")]publicobject?ToObject_Int(){returnTypedReference.ToObject(__makeref(number));}}

Author:	Sergio0694
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

jkotas · 2022-06-01T15:19:12Z

The new tests are failing on Mono. Open an issue on it and disable the tests against it.

Sergio0694 · 2022-06-01T16:22:25Z

Looks like the tests are not failing, but just can't even compile on Mono 🤔

So [SkipOnMono] didn't do the trick. I'm not seeing eg. CORECLR defined in the tests, is there a recommended way or a specific compile constant to just remove some tests entirely on a specific runtime so that they won't even be compiled?

jkotas · 2022-06-01T16:37:49Z

[ActiveIssue("https://github.com/dotnet/runtime/issues/...", TestRuntimes.Mono)]

jkotas · 2022-06-01T16:41:26Z

If it is causing the Mono AOT compiler the crash, we do not have a good way to deal with it today. I guess you can comment out the test for now.

Sergio0694 · 2022-06-01T16:43:02Z

Ah, gotcha. Will do that, thank you! 🙂

jkotas · 2022-06-02T15:07:03Z

Failures are known issues #69125 and #69192

jkotas

Thank you!

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

ghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels May 31, 2022

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment thread...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/TypedReference.cs Outdated

jkotas reviewed May 31, 2022
View reviewed changes

Comment threadsrc/coreclr/vm/typedesc.inl Outdated

Sergio0694 added 10 commits June 1, 2022 13:57

Initial partial TypedReference.ToObject managed port
61ccd7a

Port rest of mamaged TypeDesc method table logic
699cc89

Add RuntimeTypeHandle.GetElementTypeMethodTable FCall
51aba9e

Remove TypedReference.InternalToObject FCall
726fb7b

Remove throwing path, add an assert
dcfae54

Remove unnecessary TypeDesc paths
aee69f6

Remove ParamTypeDesc::m_TemplateMT and related code
e97227e

Fix TypeDesc::GetMethodTable
a5af69a

Reuse RuntimeTypeHandle.GetValueInternal to drop an FCall
5864175

Add unit tests for TypedReference.ToObject and type desc
2e8db94

Sergio0694 force-pushed the managed-typed-reference-to-object branch from 871e46c to 2e8db94Compare June 1, 2022 11:58

Move ifdef methods to TypedReference.Mono file
43eacab

Sergio0694 requested a review from marek-safar as a code owner June 1, 2022 13:24

runfoappBot mentioned this pull request Jun 1, 2022
jit.1 work item failing on mono #67888
Closed

Sergio0694 mentioned this pull request Jun 1, 2022
TypedReference.ToObject tests failing on Mono #70091
Closed

Skip new TypedReference tests on Mono
d394758

Use [ActiveIssue] instead of [SkipOnMono]
f3dee5e

Commented tests out to skip Mono AOT failure
f2e25f7

steveharter reviewed Jun 2, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/TypedReferenceTests.cs

jkotas approved these changes Jun 2, 2022
View reviewed changes

jkotas merged commit 59a3093 into dotnet:mainJun 2, 2022

Sergio0694 deleted the managed-typed-reference-to-object branch June 2, 2022 15:09

teo-tsirpanis added area-VM-coreclr and removed area-System.Reflection labels Jun 2, 2022

AndyAyersMS mentioned this pull request Jun 10, 2022
[Perf] Changes at 6/2/2022 5:58:32 PM dotnet/perf-autofiling-issues#5853
Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2022

Uh oh!

Conversation

Sergio0694 commented May 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Benchmarks

Uh oh!

ghost commented May 31, 2022

Overview

API additions (CoreCLR-only)

Benchmarks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jun 1, 2022

Uh oh!

Sergio0694 commented Jun 1, 2022

Uh oh!

jkotas commented Jun 1, 2022

Uh oh!

jkotas commented Jun 1, 2022

Uh oh!

Sergio0694 commented Jun 1, 2022

Uh oh!

Uh oh!

jkotas commented Jun 2, 2022

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Sergio0694 commented May 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Benchmarks

Uh oh!

ghost commented May 31, 2022

Overview

API additions (CoreCLR-only)

Benchmarks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jun 1, 2022

Uh oh!

Sergio0694 commented Jun 1, 2022

Uh oh!

jkotas commented Jun 1, 2022

Uh oh!

jkotas commented Jun 1, 2022

Uh oh!

Sergio0694 commented Jun 1, 2022

Uh oh!

Uh oh!

jkotas commented Jun 2, 2022

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Sergio0694 commented May 31, 2022•
edited
Loading

Sergio0694 commented May 31, 2022•
edited
Loading

Sergio0694 commented May 31, 2022•
edited
Loading

Sergio0694 commented May 31, 2022•
edited
Loading