Skip to content

Add support for symbol stripping - #70233

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged

Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
am11:feature/nativeaot/symbols-stripping

Conversation

@am11

@am11am11 commented Jun 4, 2022

Copy link
Copy Markdown
Member

Usage:

dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime

Also added a fallback for compiler introspection (clang or gcc).

Fixes#69847

@ghost

ghost commented Jun 4, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Jun 4, 2022
@am11
am11 requested a review from jkotasJune 4, 2022 03:10
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets Outdated
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets Outdated
@am11
am11force-pushed the feature/nativeaot/symbols-stripping branch from bedd546 to a531506CompareJune 4, 2022 05:19
@hez2010

hez2010 commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

How about making StripSymbols default to true?

jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
@am11

am11 commented Jun 4, 2022

Copy link
Copy Markdown
MemberAuthor

How about making StripSymbols default to true?

Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.

jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
@jkotas

jkotas commented Jun 4, 2022

Copy link
Copy Markdown
Member

Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?

@am11
am11force-pushed the feature/nativeaot/symbols-stripping branch from c9aad9e to fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
@am11
am11force-pushed the feature/nativeaot/symbols-stripping branch from 8b0b86b to 5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas reviewed Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props Outdated
@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed the feature/nativeaot/symbols-stripping branch from 5cf5a88 to cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas approved these changes Jun 5, 2022
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas

jkotas commented Jun 5, 2022

Copy link
Copy Markdown
Member

@MichalStrehovsky Could you please review this as well?

@Suchiman

Suchiman commented Jun 5, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?

@MichalStrehovsky

MichalStrehovsky commented Jun 5, 2022•
edited
Loading

Copy link
Copy Markdown
Member

How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?

<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.

The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.

MichalStrehovsky
MichalStrehovsky approved these changes Jun 5, 2022
View reviewed changes

@MichalStrehovskyMichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@am11

am11 commented Jun 6, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.

Original size of Hello World executable on linux: 18 MB
With -p:NativeDebugSymbols=false: 11 MB
With -p:StripSymbols=true: 5.7 MB

@MichalStrehovsky

MichalStrehovsky commented Jun 6, 2022

Copy link
Copy Markdown
Member

The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:

"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.

Cc @LakshanF just FYI

@MichalStrehovsky
MichalStrehovsky merged commit 374f788 into dotnet:mainJun 6, 2022
@am11
am11 deleted the feature/nativeaot/symbols-stripping branch June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky mentioned this pull request Jun 10, 2022
Closed
@LakshanFLakshanF mentioned this pull request Jun 29, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees

No one assigned

Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size

5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add support for symbol stripping by am11 · Pull Request #70233 · dotnet/runtime · GitHub
Skip to content
Add support for symbol stripping - #70233
Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged
Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Conversation
@am11
@am11am11
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Usage:
dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime
Also added a fallback for compiler introspection (clang or gcc).
Fixes#69847
@ghost
ghost
commented
Jun 4, 2022

Copy link


Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@ghostghost
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 4, 2022
@am11
am11
requested a review
from jkotasJune 4, 2022 03:10
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
bedd546 to
a531506CompareJune 4, 2022 05:19
@hez2010
hez2010
commented
Jun 4, 2022

Copy link


Copy Markdown

Contributor
How about making StripSymbols default to true?
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11
commented
Jun 4, 2022

Copy link


Copy Markdown

MemberAuthor
How about making StripSymbols default to true?
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@jkotas
jkotas
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
c9aad9e to
fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
8b0b86b to
5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
5cf5a88 to
cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas
approved these changes
Jun 5, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
commented
Jun 5, 2022

Copy link


Copy Markdown

Member
@MichalStrehovsky Could you please review this as well?
@Suchiman
Suchiman
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
@MichalStrehovsky
MichalStrehovsky
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.
The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.
MichalStrehovsky
MichalStrehovsky
approved these changes
Jun 5, 2022
View reviewed changes
@MichalStrehovskyMichalStrehovsky
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@am11
am11
commented
Jun 6, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.
Original size of Hello World executable on linux: 18 MB

With -p:NativeDebugSymbols=false: 11 MB

With -p:StripSymbols=true: 5.7 MB
@MichalStrehovsky
MichalStrehovsky
commented
Jun 6, 2022

Copy link


Copy Markdown

Member
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:
"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.
Cc @LakshanF just FYI
@MichalStrehovsky
MichalStrehovsky
merged commit 374f788
into
dotnet:mainJun 6, 2022
@am11
am11
deleted the

feature/nativeaot/symbols-stripping

branch
June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 10, 2022

Closed

@LakshanFLakshanF
mentioned this pull request
Jun 29, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees


No one assigned


Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size


5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for symbol stripping by am11 · Pull Request #70233 · dotnet/runtime · GitHub
Skip to content
Add support for symbol stripping - #70233
Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged
Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Conversation
@am11
@am11am11
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Usage:
dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime
Also added a fallback for compiler introspection (clang or gcc).
Fixes#69847
@ghost
ghost
commented
Jun 4, 2022

Copy link


Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@ghostghost
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 4, 2022
@am11
am11
requested a review
from jkotasJune 4, 2022 03:10
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
bedd546 to
a531506CompareJune 4, 2022 05:19
@hez2010
hez2010
commented
Jun 4, 2022

Copy link


Copy Markdown

Contributor
How about making StripSymbols default to true?
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11
commented
Jun 4, 2022

Copy link


Copy Markdown

MemberAuthor
How about making StripSymbols default to true?
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@jkotas
jkotas
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
c9aad9e to
fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
8b0b86b to
5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
5cf5a88 to
cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas
approved these changes
Jun 5, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
commented
Jun 5, 2022

Copy link


Copy Markdown

Member
@MichalStrehovsky Could you please review this as well?
@Suchiman
Suchiman
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
@MichalStrehovsky
MichalStrehovsky
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.
The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.
MichalStrehovsky
MichalStrehovsky
approved these changes
Jun 5, 2022
View reviewed changes
@MichalStrehovskyMichalStrehovsky
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@am11
am11
commented
Jun 6, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.
Original size of Hello World executable on linux: 18 MB

With -p:NativeDebugSymbols=false: 11 MB

With -p:StripSymbols=true: 5.7 MB
@MichalStrehovsky
MichalStrehovsky
commented
Jun 6, 2022

Copy link


Copy Markdown

Member
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:
"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.
Cc @LakshanF just FYI
@MichalStrehovsky
MichalStrehovsky
merged commit 374f788
into
dotnet:mainJun 6, 2022
@am11
am11
deleted the

feature/nativeaot/symbols-stripping

branch
June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 10, 2022

Closed

@LakshanFLakshanF
mentioned this pull request
Jun 29, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees


No one assigned


Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size


5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for symbol stripping by am11 · Pull Request #70233 · dotnet/runtime · GitHub
Skip to content
Add support for symbol stripping - #70233
Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged
Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Conversation
@am11
@am11am11
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Usage:
dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime
Also added a fallback for compiler introspection (clang or gcc).
Fixes#69847
@ghost
ghost
commented
Jun 4, 2022

Copy link


Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@ghostghost
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 4, 2022
@am11
am11
requested a review
from jkotasJune 4, 2022 03:10
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
bedd546 to
a531506CompareJune 4, 2022 05:19
@hez2010
hez2010
commented
Jun 4, 2022

Copy link


Copy Markdown

Contributor
How about making StripSymbols default to true?
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11
commented
Jun 4, 2022

Copy link


Copy Markdown

MemberAuthor
How about making StripSymbols default to true?
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@jkotas
jkotas
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
c9aad9e to
fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
8b0b86b to
5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
5cf5a88 to
cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas
approved these changes
Jun 5, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
commented
Jun 5, 2022

Copy link


Copy Markdown

Member
@MichalStrehovsky Could you please review this as well?
@Suchiman
Suchiman
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
@MichalStrehovsky
MichalStrehovsky
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.
The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.
MichalStrehovsky
MichalStrehovsky
approved these changes
Jun 5, 2022
View reviewed changes
@MichalStrehovskyMichalStrehovsky
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@am11
am11
commented
Jun 6, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.
Original size of Hello World executable on linux: 18 MB

With -p:NativeDebugSymbols=false: 11 MB

With -p:StripSymbols=true: 5.7 MB
@MichalStrehovsky
MichalStrehovsky
commented
Jun 6, 2022

Copy link


Copy Markdown

Member
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:
"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.
Cc @LakshanF just FYI
@MichalStrehovsky
MichalStrehovsky
merged commit 374f788
into
dotnet:mainJun 6, 2022
@am11
am11
deleted the

feature/nativeaot/symbols-stripping

branch
June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 10, 2022

Closed

@LakshanFLakshanF
mentioned this pull request
Jun 29, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees


No one assigned


Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size


5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add support for symbol stripping by am11 · Pull Request #70233 · dotnet/runtime · GitHub
Skip to content
Add support for symbol stripping - #70233
Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged
Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Conversation
@am11
@am11am11
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Usage:
dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime
Also added a fallback for compiler introspection (clang or gcc).
Fixes#69847
@ghost
ghost
commented
Jun 4, 2022

Copy link


Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@ghostghost
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 4, 2022
@am11
am11
requested a review
from jkotasJune 4, 2022 03:10
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
bedd546 to
a531506CompareJune 4, 2022 05:19
@hez2010
hez2010
commented
Jun 4, 2022

Copy link


Copy Markdown

Contributor
How about making StripSymbols default to true?
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11
commented
Jun 4, 2022

Copy link


Copy Markdown

MemberAuthor
How about making StripSymbols default to true?
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@jkotas
jkotas
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
c9aad9e to
fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
8b0b86b to
5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
5cf5a88 to
cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas
approved these changes
Jun 5, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
commented
Jun 5, 2022

Copy link


Copy Markdown

Member
@MichalStrehovsky Could you please review this as well?
@Suchiman
Suchiman
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
@MichalStrehovsky
MichalStrehovsky
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.
The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.
MichalStrehovsky
MichalStrehovsky
approved these changes
Jun 5, 2022
View reviewed changes
@MichalStrehovskyMichalStrehovsky
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@am11
am11
commented
Jun 6, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.
Original size of Hello World executable on linux: 18 MB

With -p:NativeDebugSymbols=false: 11 MB

With -p:StripSymbols=true: 5.7 MB
@MichalStrehovsky
MichalStrehovsky
commented
Jun 6, 2022

Copy link


Copy Markdown

Member
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:
"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.
Cc @LakshanF just FYI
@MichalStrehovsky
MichalStrehovsky
merged commit 374f788
into
dotnet:mainJun 6, 2022
@am11
am11
deleted the

feature/nativeaot/symbols-stripping

branch
June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 10, 2022

Closed

@LakshanFLakshanF
mentioned this pull request
Jun 29, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees


No one assigned


Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size


5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for symbol stripping by am11 · Pull Request #70233 · dotnet/runtime · GitHub
Skip to content
Add support for symbol stripping - #70233
Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged
Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Conversation
@am11
@am11am11
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Usage:
dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime
Also added a fallback for compiler introspection (clang or gcc).
Fixes#69847
@ghost
ghost
commented
Jun 4, 2022

Copy link


Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@ghostghost
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 4, 2022
@am11
am11
requested a review
from jkotasJune 4, 2022 03:10
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
bedd546 to
a531506CompareJune 4, 2022 05:19
@hez2010
hez2010
commented
Jun 4, 2022

Copy link


Copy Markdown

Contributor
How about making StripSymbols default to true?
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11
commented
Jun 4, 2022

Copy link


Copy Markdown

MemberAuthor
How about making StripSymbols default to true?
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@jkotas
jkotas
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
c9aad9e to
fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
8b0b86b to
5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
5cf5a88 to
cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas
approved these changes
Jun 5, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
commented
Jun 5, 2022

Copy link


Copy Markdown

Member
@MichalStrehovsky Could you please review this as well?
@Suchiman
Suchiman
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
@MichalStrehovsky
MichalStrehovsky
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.
The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.
MichalStrehovsky
MichalStrehovsky
approved these changes
Jun 5, 2022
View reviewed changes
@MichalStrehovskyMichalStrehovsky
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@am11
am11
commented
Jun 6, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.
Original size of Hello World executable on linux: 18 MB

With -p:NativeDebugSymbols=false: 11 MB

With -p:StripSymbols=true: 5.7 MB
@MichalStrehovsky
MichalStrehovsky
commented
Jun 6, 2022

Copy link


Copy Markdown

Member
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:
"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.
Cc @LakshanF just FYI
@MichalStrehovsky
MichalStrehovsky
merged commit 374f788
into
dotnet:mainJun 6, 2022
@am11
am11
deleted the

feature/nativeaot/symbols-stripping

branch
June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 10, 2022

Closed

@LakshanFLakshanF
mentioned this pull request
Jun 29, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees


No one assigned


Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size


5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Add support for symbol stripping by am11 · Pull Request #70233 · dotnet/runtime · GitHub
Skip to content
Add support for symbol stripping - #70233
Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Jun 6, 2022
Merged
Add support for symbol stripping#70233
MichalStrehovsky merged 1 commit into
dotnet:mainfrom 
am11:feature/nativeaot/symbols-stripping
Conversation
@am11
@am11am11
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Usage:
dotnet publish -c Release -p:PublishAot=true -p:StripSymbols=true --use-current-runtime
Also added a fallback for compiler introspection (clang or gcc).
Fixes#69847
@ghost
ghost
commented
Jun 4, 2022

Copy link


Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@ghostghost
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 4, 2022
@am11
am11
requested a review
from jkotasJune 4, 2022 03:10
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
bedd546 to
a531506CompareJune 4, 2022 05:19
@hez2010
hez2010
commented
Jun 4, 2022

Copy link


Copy Markdown

Contributor
How about making StripSymbols default to true?
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11
commented
Jun 4, 2022

Copy link


Copy Markdown

MemberAuthor
How about making StripSymbols default to true?
Per @MichalStrehovsky's findings #69847 (comment), other (comparable) toolchains produce unstripped binaries by default.
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@jkotas
jkotas
commented
Jun 4, 2022

Copy link


Copy Markdown

Member
Could you please also update https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/optimizing.md#special-considerations-for-linuxmacos ?
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
c9aad9e to
fc7aeabCompareJune 4, 2022 21:05
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
8b0b86b to
5cf5a88CompareJune 4, 2022 22:14
jkotas
jkotas
reviewed
Jun 4, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.props
Outdated

@am11@jkotas
Add support for symbol stripping
cca2f7e
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@am11
am11force-pushed
the
feature/nativeaot/symbols-stripping
branch
from
5cf5a88 to
cca2f7eCompareJune 4, 2022 23:10
jkotas
jkotas
approved these changes
Jun 5, 2022
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@jkotas
jkotas
commented
Jun 5, 2022

Copy link


Copy Markdown

Member
@MichalStrehovsky Could you please review this as well?
@Suchiman
Suchiman
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
@MichalStrehovsky
MichalStrehovsky
commented
Jun 5, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How is this different from setting <DebugSymbols>false, which respectively sets <NativeDebugSymbols>false which enables stripping by appending -Wl,--strip-debug to the linker args?
<DebugSymbols>false</DebugSymbols> will throw away all debugging information on all platforms.
The new <StripSymbols> option places debugging information on non-Windows systems into a separate file, similar to Windows PDB.
MichalStrehovsky
MichalStrehovsky
approved these changes
Jun 5, 2022
View reviewed changes
@MichalStrehovskyMichalStrehovsky
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@am11
am11
commented
Jun 6, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
StripSymbols strips away all the unneeded symbols from binary and place them into a separate file, not just the debug symbols.
Original size of Hello World executable on linux: 18 MB

With -p:NativeDebugSymbols=false: 11 MB

With -p:StripSymbols=true: 5.7 MB
@MichalStrehovsky
MichalStrehovsky
commented
Jun 6, 2022

Copy link


Copy Markdown

Member
The NativeAOT leg failed because there was a Helix delay of 1 hour and 40 minutes for System.IO.FileSystem.Tests:
"Queued":"2022-06-06T04:42:54.942+00:00",
"Started":"2022-06-06T06:23:06.736+00:00",
"Finished":"2022-06-06T06:23:07.158+00:00",
"Delay":"01:40:11.7940000",
"Duration":"00:00:00.4220000"

We'll have to see if this is a pattern.
Cc @LakshanF just FYI
@MichalStrehovsky
MichalStrehovsky
merged commit 374f788
into
dotnet:mainJun 6, 2022
@am11
am11
deleted the

feature/nativeaot/symbols-stripping

branch
June 6, 2022 09:10
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 10, 2022

Closed

@LakshanFLakshanF
mentioned this pull request
Jun 29, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Jul 6, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees


No one assigned


Labels

area-NativeAOT-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Symbol stripping in NativeAOT to reduce binary size


5 participants

@am11@hez2010@jkotas@Suchiman@MichalStrehovsky