JSON contract customization - #70435

Merged

krwq merged 10 commits into

dotnet:mainfrom

krwq:contract-customization

Jun 22, 2022

krwq commented Jun 8, 2022•
edited
Loading

Member

Implements: #63686

krwq requested a review from eiriktsarpalis

June 8, 2022 14:47

ghost assigned krwq

ghost added area-System.Text.Json new-api-needs-documentation labels

ghost commented Jun 8, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost commented Jun 8, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds contract customization.

This is WIP, it's easier to create comments and track remaining work this way

Author:	krwq
Assignees:	krwq
Labels:	`area-System.Text.Json`, `new-api-needs-documentation`
Milestone:	-

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Outdated

krwq force-pushed the contract-customization branch from e7b982b to bb56c48Compare

June 14, 2022 09:56

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/JsonPropertyDictionary.ValueList.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/JsonPropertyDictionary.ValueList.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/CastingConverter.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/CastingConverter.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/CastingConverter.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...ystem.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.HandlePropertyName.cs

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

eiriktsarpalis reviewed

View reviewed changes

.../System.Text.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.cs

eiriktsarpalis reviewed

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonMetadataServices.cs

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfoOfT.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfoOfT.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfoOfT.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfoOfT.cs Outdated

eiriktsarpalis reviewed

View reviewed changes

....Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonPropertyInfo.cs

address feedback

6a2b467

eiriktsarpalis reviewed

View reviewed changes

...stem.Text.Json/tests/System.Text.Json.Tests/Serialization/TypeInfoResolverFunctionalTests.cs

eiriktsarpalis reviewed

View reviewed changes

...stem.Text.Json/tests/System.Text.Json.Tests/Serialization/TypeInfoResolverFunctionalTests.cs

eiriktsarpalis reviewed

View reviewed changes

...stem.Text.Json/tests/System.Text.Json.Tests/Serialization/TypeInfoResolverFunctionalTests.cs

eiriktsarpalis reviewed

View reviewed changes

...stem.Text.Json/tests/System.Text.Json.Tests/Serialization/TypeInfoResolverFunctionalTests.cs

eiriktsarpalis reviewed

View reviewed changes

...stem.Text.Json/tests/System.Text.Json.Tests/Serialization/TypeInfoResolverFunctionalTests.cs

eiriktsarpalis reviewed

View reviewed changes

....Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonPropertyInfo.cs

eiriktsarpalis commented Jun 21, 2022

Member

I think we need to add more tests for collection and dictionary metadata. Current set seems too focused on objects only.

eiriktsarpalis commented Jun 21, 2022

Member

FWIW I ran the benchmark suite comparing the PR branch with the base commit and found no regressions. We should be good on that front.

eiriktsarpalis added 2 commits

June 21, 2022 19:21

Add acceptance tests for DataContract attributes & Specified pattern (#…

8cce77c

…11)

Add private field serialization acceptance test (#13)

d03d124

eiriktsarpalis reviewed

View reviewed changes

....Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonPropertyInfo.cs

krwq added 2 commits

June 21, 2022 23:53

tests, PR feedback (#14)

01119a8

* PR feedback and extra tests
* Shorten class name, remove incorrect check (not true for polimorphic cases)

Make parameter matching for custom properties map property Name with …

91bdc9e

…parameter (#16)

krwq marked this pull request as ready for review

June 22, 2022 09:19

krwq mentioned this pull request

Add APIs to JSON Contract customization #71123

Closed

16 tasks

krwqand others added 2 commits

June 22, 2022 13:54

Test static initialization with JsonTypeInfo (#17)

bb32820

Fix test failures and proper fix this time (#18)

07aede0

* Fix test failures and proper fix this time
* reinstate ActiveIssueAttribute
* PR feedback and adjust couple of tests which don't set TypeInfoResolver
* fix IAsyncEnumerable tests
* Lock JsonSerializerOptions in JsonTypeInfo.EnsureConfigured()
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>

eiriktsarpalis approved these changes

View reviewed changes

krwq merged commit 897b2a3 into dotnet:main

eiriktsarpalis mentioned this pull request

Rewire polymorphism metadata to the contract model #71346

Merged

dakersnar mentioned this pull request

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties> #71392

Closed

krwq added a commit to krwq/runtime-1 that referenced this pull request

Add tests for contract customization per feedback indotnet#70435

6162085

krwq mentioned this pull request

Add tests for contract customization per feedback in #70435 #71529

Merged

krwq added a commit that referenced this pull request

Add tests for contract customization per feedback in#70435(#71529)

4935319

kunalspathak mentioned this pull request

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties> #71645

Closed

krwq mentioned this pull request

Re-enable tests for #66421 #73052

Merged

eiriktsarpalis mentioned this pull request

Fix InvalidCastException when casting a polymorphic converter #73259

Merged

ghost locked as resolved and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.