Skip to content

Base64 library tests: use full encoding map - #71006

Merged
adamsitnik merged 1 commit into
dotnet:mainfrom
a74nh:a74nh_base64full
Jun 22, 2022
Merged

Base64 library tests: use full encoding map#71006
adamsitnik merged 1 commit into
dotnet:mainfrom
a74nh:a74nh_base64full

Conversation

@a74nh

Copy link
Copy Markdown
Contributor

InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.

This was spotted whilst upstreaming:
dotnet/performance#2479

InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.
This was spotted whilst upstreaming:
dotnet/performance#2479
@ghostghost added community-contribution Indicates that the PR has been added by a community member area-System.Memory labels Jun 20, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.

This was spotted whilst upstreaming:
dotnet/performance#2479

Author:a74nh
Assignees:-
Labels:

area-System.Memory, community-contribution

Milestone:-

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @a74nh !

@adamsitnik
adamsitnik merged commit 250e1b0 into dotnet:mainJun 22, 2022
@a74nh
a74nh deleted the a74nh_base64full branch June 22, 2022 09:21
@ghostghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Memorycommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@a74nh@adamsitnik