Skip to content

Update design docs to reflect our new marshaller design from partner feedback - #71017

Merged
jkoritzinsky merged 5 commits into
dotnet:mainfrom
jkoritzinsky:updated-design-docs
Jun 23, 2022
Merged

Update design docs to reflect our new marshaller design from partner feedback#71017
jkoritzinsky merged 5 commits into
dotnet:mainfrom
jkoritzinsky:updated-design-docs

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Jun 20, 2022

Copy link
Copy Markdown
Member

The interop team has been working on new designs for our source-generated marshallers. Now that we're starting implementation in the runtime of these new marshallers, let's make sure to follow our "write it down" culture so we have a record of why we did what we did for our future selves.

@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jun 20, 2022
@ghost

ghost commented Jun 20, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

The interop team has been working on new designs for our source-generated marshallers. Now that we're starting implementation in the runtime of these new marshallers, let's make sure to follow our "write it down" culture so we have a record of why we did what we did for our future selves.

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:-

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jun 21, 2022
View reviewed changes
Comment threaddocs/design/libraries/LibraryImportGenerator/Pipeline.md Outdated
Comment threaddocs/design/libraries/LibraryImportGenerator/SpanMarshallers.md Outdated
Comment threaddocs/design/libraries/LibraryImportGenerator/StructMarshalling.md Outdated
@jkoritzinsky@AaronRobinsonMSFT
Apply suggestions from code review
454107c
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jun 22, 2022
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure @elinor-fung signs off on this too.

elinor-fung
elinor-fung reviewed Jun 22, 2022
View reviewed changes
Comment threaddocs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md Outdated
Comment threaddocs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md Outdated
Comment threaddocs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md
elinor-fung
elinor-fung approved these changes Jun 22, 2022
View reviewed changes
Comment threaddocs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md Outdated
@jkoritzinsky@elinor-fung
Update docs/design/libraries/LibraryImportGenerator/UserTypeMarshalli…
443fdc7
…ngV2.md
Co-authored-by: Elinor Fung <elfung@microsoft.com>
@jkoritzinsky
jkoritzinsky merged commit 9e8c7a8 into dotnet:mainJun 23, 2022
@jkoritzinsky
jkoritzinsky deleted the updated-design-docs branch June 23, 2022 03:17
@ghostghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkoritzinsky@AaronRobinsonMSFT@elinor-fung