Skip to content

Switch to PREEMPT mode when calling CoTaskMem* APIs - #71031

Merged
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime_70973
Jun 21, 2022
Merged

Switch to PREEMPT mode when calling CoTaskMem* APIs#71031
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime_70973

Conversation

@AaronRobinsonMSFT

@AaronRobinsonMSFTAaronRobinsonMSFT commented Jun 21, 2022

Copy link
Copy Markdown
Member

Fixes#70973

This enables WinForms to pass.

Still need to consider other COM entry points (for example, ComPreStubWorker).

@AaronRobinsonMSFTAaronRobinsonMSFT added this to the 7.0.0 milestone Jun 21, 2022
jkotas
jkotas reviewed Jun 21, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/comtoclrcall.cpp Outdated
@jkotas

jkotas commented Jun 21, 2022

Copy link
Copy Markdown
Member

Still need to consider other COM entry points (for example, ComPreStubWorker).

I think ComPreStubWorker is the only one that needs it. There may be other entrypoints for various corner cases, but I do not think we need to boil the ocean to add this check everywhere.

@AaronRobinsonMSFT
Match Reverse P/Invoke error message style.
9a86d5e
Add check in ComPreStubWorker().
@AaronRobinsonMSFT
AaronRobinsonMSFT marked this pull request as ready for review June 21, 2022 03:15
jkotas
jkotas reviewed Jun 21, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/comtoclrcall.cpp Outdated
jkotas
jkotas reviewed Jun 21, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/comtoclrcall.cpp Outdated
jkotas
jkotas reviewed Jun 21, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/comtoclrcall.cpp Outdated
jkotas
jkotas approved these changes Jun 21, 2022
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Jun 21, 2022

Copy link
Copy Markdown
MemberAuthor

Failure is #70969.

@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 786ec9d into dotnet:mainJun 21, 2022
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the runtime_70973 branch June 21, 2022 15:32
@AaronRobinsonMSFTAaronRobinsonMSFT mentioned this pull request Jun 22, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes

Assignees

@AaronRobinsonMSFTAaronRobinsonMSFT

Labels

area-Interop-coreclr

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

cli xUnit tests fail since https://github.com/dotnet/runtime build 20220616.9

2 participants

@AaronRobinsonMSFT@jkotas