Skip to content

Exposing AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi for ITrigonometricFunctions - #71033

Merged
tannergooding merged 3 commits into
dotnet:mainfrom
tannergooding:generic-math-trig
Jun 22, 2022
Merged

Exposing AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi for ITrigonometricFunctions#71033
tannergooding merged 3 commits into
dotnet:mainfrom
tannergooding:generic-math-trig

Conversation

@tannergooding

@tannergoodingtannergooding commented Jun 21, 2022

Copy link
Copy Markdown
Member

This exposes the AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi functions approved for the ITrigonometricFunctions interface.

TODO

[ ] - Add tests for Atan2Pi

@ghost

ghost commented Jun 21, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jun 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This exposes the AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi functions approved for the ITrigonometricFunctions interface.

TODO

[ ] - Add tests for Atan2Pi

Author:tannergooding
Assignees:tannergooding
Labels:

area-System.Numerics, new-api-needs-documentation

Milestone:-

@huoyaoyuan

huoyaoyuan commented Jun 21, 2022

Copy link
Copy Markdown
Member

In #53675 I added tests for +-0/Inf etc from IEEE754 spec.

gfoidl
gfoidl reviewed Jun 21, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Double.cs
adamsitnik
adamsitnik reviewed Jun 21, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Double.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Double.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/ITrigonometricFunctions.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/ITrigonometricFunctions.cs
Comment thread...tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Double.cs
adamsitnik
adamsitnik approved these changes Jun 21, 2022
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tannergooding !

@tannergooding
tannergooding merged commit 0855da7 into dotnet:mainJun 22, 2022
@tannergooding

tannergooding commented Jun 22, 2022

Copy link
Copy Markdown
MemberAuthor

Going to finish adding the Atan2 tests in follow up PR so this makes the snap.

@tannergoodingtannergooding mentioned this pull request Jun 23, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes
+1 more reviewer
@gfoidlgfoidlgfoidl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-System.Numericsnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding@huoyaoyuan@gfoidl@adamsitnik