Skip to content

Delete fgMorphGetStructAddr - #71078

Merged
EgorBo merged 1 commit into
dotnet:mainfrom
SingleAccretion:Delete-fgMorphGetStructAddr
Jun 29, 2022
Merged

Delete fgMorphGetStructAddr#71078
EgorBo merged 1 commit into
dotnet:mainfrom
SingleAccretion:Delete-fgMorphGetStructAddr

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

After #68986, we do not need it in block morphing.

Includes additional cleanup of dead/unnecessary block morphing code.

Diffs - couple positive ones on x86 where we keep the block copy when assigning to a promoted SIMD.

Sample IR diff
- [000083] -A-X-+----- * COMMA void- [000076] -A-X------- +--* COMMA void- [000071] -A--------- | +--* ASG byref- [000070] D------N--- | | +--* LCL_VAR byref V12 tmp10- [000067] -A--------- | | \--* COMMA byref- [000065] -A--------- | | +--* ASG simd8 (copy)- [000063] D------N--- | | | +--* LCL_VAR simd8 <System.Numerics.Vector2> V11 tmp9- [000011] -----+-N--- | | | \--* CNS_VEC simd8 <0x00000000, 0x00000000>- [000069] ----------- | | \--* ADDR byref- [000066] -------N--- | | \--* LCL_VAR simd8 <System.Numerics.Vector2> V11 tmp9- [000075] -A-X------- | \--* ASG float- [000072] D------N--- | +--* LCL_VAR float V07 tmp5- [000074] ---X------- | \--* IND float- [000073] ----------- | \--* LCL_VAR byref V12 tmp10 Zero Fseq[X]- [000082] -A-X------- \--* ASG float- [000077] D------N--- +--* LCL_VAR float V08 tmp6- [000081] ---X------- \--* IND float- [000080] ----------- \--* ADD byref- [000078] ----------- +--* LCL_VAR byref V12 tmp10- [000079] ----------- \--* CNS_INT int 4 Fseq[Y]+ [000014] -A---+----- * ASG simd8 (copy)+ [000012] D----+-N--- +--* LCL_VAR simd8 <System.Numerics.Vector2>(P) V03 tmp1+ +--* float V03.X (offs=0x00) -> V07 tmp5+ +--* float V03.Y (offs=0x04) -> V08 tmp6+ [000011] -----+----- \--* CNS_VEC simd8 <0x00000000, 0x00000000>

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Jun 21, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

After #68986, we do not need it in block morphing.

Includes additional cleanup of dead/unnecessary block morphing code.

No diffs are expected.

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@SingleAccretion
SingleAccretion marked this pull request as ready for review June 22, 2022 12:28
@SingleAccretion

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@EgorBo

Copy link
Copy Markdown
Member

Thanks, let's wait for the active CI pipelines to finish

@EgorBo
EgorBo merged commit 120db95 into dotnet:mainJun 29, 2022
@SingleAccretion
SingleAccretion deleted the Delete-fgMorphGetStructAddr branch June 30, 2022 10:57
@ghostghost locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@SingleAccretion@EgorBo