Skip to content

Add idIsBound() check in emitDispJumpList() - #71086

Merged
kunalspathak merged 2 commits into
dotnet:mainfrom
kunalspathak:jmplist
Jun 22, 2022
Merged

Add idIsBound() check in emitDispJumpList()#71086
kunalspathak merged 2 commits into
dotnet:mainfrom
kunalspathak:jmplist

Conversation

@kunalspathak

Copy link
Copy Markdown
Contributor

For jumps that are injected in the prolog of initialization need to be handled inside emitDispJumpList().

Fixes: #71049

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 21, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

For jumps that are injected in the prolog of initialization need to be handled inside emitDispJumpList().

Fixes: #71049

Author:kunalspathak
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for now.

We should probably add a helper to commonize/print jmp instrDescs. E.g., you could also print Bound ones, like the disasm code:

 if (id->idIsBound())
{
emitPrintLabel(id->idAddr()->iiaIGlabel);
}
else
{
printf("L_M%03u_" FMT_BB, emitComp->compMethodID, id->idAddr()->iiaBBlabel->bbNum);
}

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

We should probably add a helper to commonize/print jmp instrDescs. E.g., you could also print Bound ones, like the disasm code:

This needs modification as part of #70389. Will do it at that time.

@kunalspathak
kunalspathak merged commit ead19a3 into dotnet:mainJun 22, 2022
@kunalspathak
kunalspathak deleted the jmplist branch June 22, 2022 04:36
@ghostghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AVs in emitDispJumpList

2 participants

@kunalspathak@BruceForstall