Use IndexOfAny in HttpListener.HandleAuthentication

[stephentoub]

Just cleaning up a manual loop that can instead be IndexOfAny.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Just cleaning up a manual loop that can instead be IndexOfAny.

Author:	stephentoub
Assignees:	stephentoub
Labels:	area-System.Net.Http
Milestone:	-

[wfurt]

C:\h\w\A2D70905\w\A3BB094B\e>"C:\h\w\A2D70905\p\dotnet.exe" exec --runtimeconfig System.Net.HttpListener.Tests.runtimeconfig.json --depsfile System.Net.HttpListener.Tests.deps.json xunit.console.dll System.Net.HttpListener.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Net.HttpListener.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Net.HttpListener.Tests (found 286 of 299 test cases)
Starting: System.Net.HttpListener.Tests (parallel test collections = on, max threads = 2)
System.Net.Tests.HttpListenerAuthenticationTests.NtlmAuthentication_InvalidRequestHeaders_ReturnsExpectedStatusCode(header: null, statusCode: Unauthorized) [FAIL]
System.ArgumentOutOfRangeException : Length cannot be less than zero. (Parameter 'length')
Stack Trace:
/_/src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs(385,0): at System.String.Compare(String strA, Int32 indexA, String strB, Int32 indexB, Int32 length, StringComparison comparisonType)
/_/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListener.Windows.cs(816,0): at System.Net.HttpListener.HandleAuthentication(HttpListenerSession session, RequestContextBase memoryBlob, Boolean& 

looks related

[wfurt]

This will work. But I think this is only used in the condition bellow to guard if any character was found. e.g. you can simplify that without assignment as

- if (index < authorizationHeader.Length)+ if (index >= 0)

[stephentoub]

index is also referenced later in the method.

[wfurt]

yeah, I missed that reading it on GH. However, without going to the first block, headerScheme should remain AuthenticationSchemes.None and we will error out without reaching the next index use. Not sure if HttpListener is worth of any more troubles.

[wfurt]

LGTM