Skip to content

[NativeAOT] Enable dynamic linking of ucrt for release runtime - #71182

Merged
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:dynamic-crt
Jun 23, 2022
Merged

[NativeAOT] Enable dynamic linking of ucrt for release runtime#71182
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:dynamic-crt

Conversation

@jkotas

@jkotasjkotas commented Jun 23, 2022

Copy link
Copy Markdown
Member

This is enabled for release runtime only, same as how we do it for regular CoreCLR builds.

@jkotas
[NativeAOT] Enable dynamic linking of ucrt for release runtime
05a5792
This is enabled for release runtime only, same as how we do it for regular CoreCLR builds.
@ghostghost assigned jkotasJun 23, 2022
@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Jun 23, 2022
@ghost

ghost commented Jun 23, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This is enabled for release runtime only, same as how we do it for regular CoreCLR builds.

Author:jkotas
Assignees:jkotas
Labels:

area-Infrastructure-coreclr

Milestone:-

@jkotas

jkotas commented Jun 23, 2022

Copy link
Copy Markdown
MemberAuthor

This makes AOT helloworld.exe about 200kB smaller.

jkotas
jkotas commented Jun 23, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Windows.props
jkotas
jkotas commented Jun 23, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/BuildIntegration.proj Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jun 23, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/BuildIntegration.proj
MichalStrehovsky
MichalStrehovsky approved these changes Jun 23, 2022
View reviewed changes

@MichalStrehovskyMichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas

jkotas commented Jun 23, 2022

Copy link
Copy Markdown
MemberAuthor

Test failure is #70969

@jkotas
jkotas merged commit 05ae801 into dotnet:mainJun 23, 2022
@jkotas
jkotas deleted the dynamic-crt branch June 23, 2022 06:26
@ghostghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT left review comments
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees

@jkotasjkotas

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@MichalStrehovsky@AaronRobinsonMSFT