Skip to content

[Mono] Remove unused field in Exception.Mono - #71202

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
steveisok:remove-unneeded-member
Jun 29, 2022
Merged

[Mono] Remove unused field in Exception.Mono#71202
stephentoub merged 1 commit into
dotnet:mainfrom
steveisok:remove-unneeded-member

Conversation

@steveisok

Copy link
Copy Markdown
Member

#70970 was merged with a field that was unused. This PR removes it.

dotnet#70970 was merged with a field that was unused. This PR removes it.
@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@marek-safar

Copy link
Copy Markdown
Contributor

@stephentoub wondering why CA1823 didn't catch it

@stephentoub

stephentoub commented Jun 23, 2022

Copy link
Copy Markdown
Member

wondering why CA1823 didn't catch it

Because it's on a type explicitly attributed with [StructLayout(LayoutKind.Sequential)] and the rule explicitly avoids warning about fields on such types, as even if they're not referenced explicitly, removing them would potentially impact well-defined offsets.

@stephentoub
stephentoub merged commit ade0b21 into dotnet:mainJun 29, 2022
@akoeplinger
akoeplinger deleted the remove-unneeded-member branch July 11, 2022 18:01
@ghostghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@marek-safar@stephentoub@lambdageek