[Android] Fix some System.Net tests by simonrozsival · Pull Request #71385 · dotnet/runtime

simonrozsival · 2022-06-28T14:03:51Z

We use some self-signed certificates in our tests and Android doesn't allow traffic to the servers using those certificates. In order to get the tests to work, we need to configure include the public keys in the .apk we build and use Network Security Configuration to trust our self-signed certificates.

Closes#37087
Fixes most of #68206
Closes#69870
Fixes Android-related failures in #72209

…tem-net-security-tests-on-android

ghost · 2022-06-28T14:04:08Z

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes most of the tests that were disabled in #68206.

We use some self-signed certificates in our tests and Android doesn't allow traffic to the servers using those certificates. In order to get the tests to work, we need to configure include the public keys in the .apk we build and use Network Security Configuration to trust our self-signed certificates.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Security`
Milestone:	-

simonrozsival · 2022-06-28T14:04:47Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-06-28T14:05:04Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2022-06-29T13:22:43Z

The tests pass on Android devices (arm and arm64 lanes) and fail on emulators (x86 and x64 lanes). I'm converting this PR to a draft until I figure out why.

simonrozsival · 2022-07-01T09:55:02Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-01T09:55:25Z

Azure Pipelines successfully started running 1 pipeline(s).

…logs" This reverts commit 039d051.

…tem-net-security-tests-on-android

…sets

simonrozsival · 2022-07-04T15:56:05Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-04T15:56:26Z

Azure Pipelines successfully started running 1 pipeline(s).

…tem-net-security-tests-on-android

simonrozsival · 2022-07-19T09:41:04Z

/azp run runtime-extra-platforms

simonrozsival · 2022-07-19T11:45:13Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-19T11:45:36Z

Azure Pipelines successfully started running 1 pipeline(s).

…tem-net-security-tests-on-android

simonrozsival · 2022-07-19T18:34:48Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-19T18:35:01Z

Azure Pipelines successfully started running 1 pipeline(s).

…tem-net-security-tests-on-android

simonrozsival · 2022-07-19T18:37:08Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-07-19T18:37:22Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2022-07-20T09:38:36Z

All of the failing tests are know issues and are also happening on main. This PR is now ready to be merged.

simonrozsival added 7 commits June 28, 2022 09:42

Implement IncludeNetworkSecurityConfig
45bedb1

Use IncludeNetworkSecurityConfig
575bed7

Fix tests
5e6b3fa

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto fix-sys…
93b5648
…tem-net-security-tests-on-android

Remove active issue attributes
89296f6

Rename certificate file
f7ca23a

Revert unnecessary changes
ff09605

ghost added the area-System.Net.Security label Jun 28, 2022

ghost assigned simonrozsival Jun 28, 2022

simonrozsival marked this pull request as draft June 29, 2022 13:22

TMP: re-throw caught exception to reveal more information in logs
039d051

Revert "TMP: re-throw caught exception to reveal more information in …
98db19b
…logs" This reverts commit 039d051.

This was referenced Jul 1, 2022
System.Net.Requests.Tests tests fail on Android #37087
Closed
Add Android network security configuration dotnet/runtime-assets#251
Merged

simonrozsival added 4 commits July 1, 2022 18:28

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto fix-sys…
a1616c3
…tem-net-security-tests-on-android

TMP: add and update res folders until they are merged into runtime-as…
a4c25b4
…sets

Fix System.Net.Requests tests
4acb16b

Re-enable System.Net.Http functional tests
3dad204

simonrozsival changed the title ~~[Android] Fix some System.Net.Security tests~~[Android] Fix some System.NettestsJul 4, 2022

simonrozsival changed the title ~~[Android] Fix some System.Nettests~~[Android] Fix some System.Net testsJul 4, 2022

simonrozsival added 2 commits July 7, 2022 11:29

Try fixing failing test
b1806a1

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto fix-sys…
a440d13
…tem-net-security-tests-on-android

simonrozsival added 4 commits July 19, 2022 07:14

Fix http client handler factory on Browser
a200ac6

Skip failing test
59f7e61

Fix net48 build
35b9ed0

Revert unintentional change in WinHttpHandler tests
8db4b45

simonrozsival added 3 commits July 19, 2022 17:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto fix-sys…
6ad3302
…tem-net-security-tests-on-android

Avoid using unsupported property on Browser
33d52f1

Remove unnecessary default value
8608d46

This was referenced Jul 19, 2022
normal-microsoft.extensions.configuration.binder.tests work item #72465
Closed
System.Net.Http.Functional.Tests.SyncHttpHandler_DiagnosticsTest.SendAsync_SuppressedGlobalStaticPropagationEnvVar failing in CI #72428
Closed

Avoid using unsupported property on Browser
c07330b

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto fix-sys…
825654a
…tem-net-security-tests-on-android

simonrozsival marked this pull request as ready for review July 20, 2022 09:38

simonrozsival merged commit e9b40f5 into dotnet:mainJul 20, 2022

simonrozsival mentioned this pull request Jul 20, 2022
[Android] Some System.Net.Security tests are failing #68206
Closed

runfoappBot mentioned this pull request Jul 20, 2022
system.io.compression.tests.zipfile_extract.extracttodirectoryunicode #72537
Closed

antonfirsov mentioned this pull request Jul 21, 2022
Recent Android test refactor broke HttpStress builds #72598
Closed

This was referenced Jul 21, 2022
[WinHttp] Manual_CertificateOnlySentWhenValid_Success fails with WINHTTP_CALLBACK_STATUS_REQUEST_ERROR in rolling CI #69238
Closed
Unexpected EOF trying to read request header LoopbackServer #56798
Closed

rzikm mentioned this pull request Jul 25, 2022
Fix SendAsync_GetWithInvalidHostHeader_ThrowsException #72779
Merged

karelz added this to the 7.0.0 milestone Aug 7, 2022

ghost locked as resolved and limited conversation to collaborators Sep 6, 2022

Uh oh!

Conversation

simonrozsival commented Jun 28, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 28, 2022

Uh oh!

simonrozsival commented Jun 28, 2022

Uh oh!

azure-pipelinesBot commented Jun 28, 2022

Uh oh!

simonrozsival commented Jun 29, 2022

Uh oh!

simonrozsival commented Jul 1, 2022

Uh oh!

azure-pipelinesBot commented Jul 1, 2022

Uh oh!

simonrozsival commented Jul 4, 2022

Uh oh!

azure-pipelinesBot commented Jul 4, 2022

Uh oh!

simonrozsival commented Jul 19, 2022

Uh oh!

simonrozsival commented Jul 19, 2022

Uh oh!

azure-pipelinesBot commented Jul 19, 2022

Uh oh!

simonrozsival commented Jul 19, 2022

Uh oh!

azure-pipelinesBot commented Jul 19, 2022

Uh oh!

simonrozsival commented Jul 19, 2022

Uh oh!

azure-pipelinesBot commented Jul 19, 2022

Uh oh!

simonrozsival commented Jul 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

simonrozsival commented Jun 28, 2022•
edited
Loading