Skip to content

Consolidate Newtonsoft versions - #71402

Merged
jkoritzinsky merged 4 commits into
dotnet:mainfrom
am11:feature/external/newtonsoft-versions
Jul 11, 2022
Merged

Consolidate Newtonsoft versions#71402
jkoritzinsky merged 4 commits into
dotnet:mainfrom
am11:feature/external/newtonsoft-versions

Conversation

@am11

@am11am11 commented Jun 28, 2022

Copy link
Copy Markdown
Member
Newtonsoft.Json => v13.0.1
Newtonsoft.Json.Bson => v1.0.2

@am11
am11 requested a review from marek-safar as a code ownerJune 28, 2022 20:40
@ghost

ghost commented Jun 28, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Jun 28, 2022
jkoritzinsky
jkoritzinsky reviewed Jun 28, 2022
View reviewed changes

@jkoritzinskyjkoritzinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't move the projects under the installer test assets to use the versions in eng/Versions.props as they are copied over to Helix and built independently of the rest of the repo.

@ghost

ghost commented Jun 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details
Newtonsoft.Json => v13.0.1
Newtonsoft.Json.Bson => v1.0.2
Author:am11
Assignees:-
Labels:

area-Infrastructure, community-contribution

Milestone:-

@am11

am11 commented Jun 28, 2022

Copy link
Copy Markdown
MemberAuthor

@jkoritzinsky, I know. That's why I have added an additional property for those projects.

@jkoritzinsky

jkoritzinsky commented Jun 28, 2022

Copy link
Copy Markdown
Member

I totally missed that in the diff. This looks good to me then! I'd like to get some feedback from the owners of the host tests before approving. @vitek-karas@agocke

@am11
Set JsonTextReader's MaxDepth to null
21005c8
In v13, defaults are changed from null to 64.
@am11
am11force-pushed the feature/external/newtonsoft-versions branch from 2efecd6 to 21005c8CompareJune 28, 2022 22:55
vitek-karas
vitek-karas reviewed Jun 29, 2022
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props
vitek-karas
vitek-karas approved these changes Jun 29, 2022
View reviewed changes

@vitek-karasvitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The host/hostests changes look good. Thanks a lot!

@am11
am11 requested review from radical and thaystg as code ownersJuly 11, 2022 04:47
@am11

am11 commented Jul 11, 2022

Copy link
Copy Markdown
MemberAuthor

@jkoritzinsky, this one is ready. Other repos have also aligned to this version of Newtonsoft (e.g. dotnet/sdk#26173).

@jkoritzinsky
jkoritzinsky merged commit 35d3f2b into dotnet:mainJul 11, 2022
@jakobbotschjakobbotsch mentioned this pull request Jul 11, 2022
Closed
@am11am11 mentioned this pull request Jul 11, 2022
Merged
@am11
am11 deleted the feature/external/newtonsoft-versions branch July 24, 2022 07:28
@ghostghost locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky left review comments
@vitek-karasvitek-karasvitek-karas approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystg
@radicalradicalAwaiting requested review from radical

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@am11@jkoritzinsky@vitek-karas