Uh oh!
There was an error while loading. Please reload this page.
Integrate mibc mono config extension - #71657
Conversation
ghost
commented
Jul 5, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
1e4edb1 to
bd6e6a0Comparemdh1418
commented
Jul 5, 2022
It looks like the Runtime value still shows up as |
brianrob
commented
Jul 5, 2022
@mdh1418, your change to add 0x4 to the With regard to making the value "Mono" show up properly, you will want to update https://github.com/microsoft/perfview/blob/main/src/TraceEvent/Parsers/ClrTraceEventParser.cs#L12694. This will cover PerfView and TraceEvent, and then any tools that pick-up new versions of TraceEvent. |
mdh1418
commented
Jul 5, 2022
Yes, I believe the Sku value 0x4 makes it to the .nettrace through a rundown event runtime/src/mono/mono/eventpipe/ep-rt-mono.c Line 2872 in cc0ccbe runtime/src/coreclr/tools/dotnet-pgo/Program.cs Lines 1776 to 1777 in cc0ccbe Thanks, I'll make changes to ClrTraceEventParser and see how it reflects locally! |
brianrob
commented
Jul 5, 2022
@mdh1418 sounds good. What you've described sounds right to me. You will want to make the change to TraceEvent locally and then patch in the updated DLL where dotnet-pgo picks it up. You can do this all locally, and assuming it works, then you'd just need to take a new version of TraceEvent into dotnet-pgo. |
mdh1418
commented
Jul 5, 2022
@brianrob I was able to verify that the MibcConfig section of the .mibc profile reflected I can put up a PR on perfview with the single line change and we can update the TraceEventVersion used in this repo to whichever version that PR makes it to. |
brianrob
commented
Jul 5, 2022
Sounds great! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1cf769f to
c9efb02Compare
Follow up to #71359.
With .mibc profiles now containing a MibcConfig, there are a couple of places that can use some modifications to better integrate this change.
4)This PR makes the following changes:
0x4as"Mono"(follow up on Add a config to MIBC format #71359 (comment))