Skip to content

Remove implicit fallback to reflection-based serialization - #71746

Merged
eiriktsarpalis merged 11 commits into
dotnet:mainfrom
eiriktsarpalis:jsonserializer-breaking-change
Jul 7, 2022
Merged

Remove implicit fallback to reflection-based serialization#71746
eiriktsarpalis merged 11 commits into
dotnet:mainfrom
eiriktsarpalis:jsonserializer-breaking-change

Conversation

@eiriktsarpalis

Copy link
Copy Markdown
Member

Makes the following changes:

…t#71714
Include JsonSerializerContext in JsonSerializerOptions copy constructor. Fixdotnet#71716
Move reflection-based converter resolution out of JsonSerializerOptions. Fixdotnet#68878
@ghost

ghost commented Jul 7, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jul 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Makes the following changes:

Author:eiriktsarpalis
Assignees:-
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone:-

@eiriktsarpaliseiriktsarpalis added this to the 7.0.0 milestone Jul 7, 2022
Comment threadsrc/libraries/System.Text.Json/ref/System.Text.Json.cs
@eiriktsarpalis
eiriktsarpalis requested a review from krwqJuly 7, 2022 20:09
…ion/JsonSerializerOptions.Converters.cs
Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
krwq
krwq approved these changes Jul 7, 2022
@eiriktsarpalis
eiriktsarpalis merged commit 8e0a132 into dotnet:mainJul 7, 2022
@eiriktsarpalis
eiriktsarpalis deleted the jsonserializer-breaking-change branch July 7, 2022 23:23
@ghostghost locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.