Skip to content

[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875

Merged
radical merged 10 commits into
dotnet:mainfrom
radical:disable-tests-highaot
Jul 12, 2022
Merged

[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom
radical:disable-tests-highaot

Conversation

@radical

@radicalradical commented Jul 9, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical added the arch-wasm WebAssembly architecture label Jul 9, 2022
@ghostghost assigned radicalJul 9, 2022
@ghost

ghost commented Jul 9, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    library tests, and EAT.

Issue: #71848

Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@radical

radical commented Jul 9, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@ghost

ghost commented Jul 9, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    library tests, and EAT.

Issue: #71848

Author:radical
Assignees:radical
Labels:

arch-wasm, area-Infrastructure-libraries

Milestone:-

@azure-pipelines

azure-pipelinesBot commented Jul 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Jul 9, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Jul 9, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radicalradical changed the title [wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical changed the title [wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical changed the title [wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical

radical commented Jul 10, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 10, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical changed the title [wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical

radical commented Jul 11, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 11, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing

lewing commented Jul 11, 2022

Copy link
Copy Markdown
Member

cc @agocke

@radical

radical commented Jul 11, 2022

Copy link
Copy Markdown
MemberAuthor

Many jobs failing due to #71981 .

I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.

@radical

radical commented Jul 11, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 11, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radicalradical mentioned this pull request Jul 12, 2022
Merged
@radical

radical commented Jul 12, 2022

Copy link
Copy Markdown
MemberAuthor

Some of the failures are fixed by #71976 .

And we seem to have new tests failing with the same linker error now:

[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical

radical commented Jul 12, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jul 12, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@runfoapprunfoappBot mentioned this pull request Jul 12, 2022
Closed
@radicalradical mentioned this pull request Jul 12, 2022
Closed
@radical

radical commented Jul 12, 2022

Copy link
Copy Markdown
MemberAuthor

The coreclr failure is #71995 .
The wasm/debugger failure is intermittent.

@radical
radical merged commit cf83273 into dotnet:mainJul 12, 2022
@radical
radical deleted the disable-tests-highaot branch July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis reviewed Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
var dictionary = new Dictionary<object, object>();
// Uri is an unsupported dictionary key.
dictionary.Add(new Uri("http://foo"), "bar");
dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");

@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq

@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.

@ghostghost locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues by radical · Pull Request #71875 · dotnet/runtime · GitHub
Skip to content
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues - #71875
Merged
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Jul 12, 2022
Merged
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues#71875
radical merged 10 commits into
dotnet:mainfrom 
radical:disable-tests-highaot
Conversation
@radical
@radicalradical
commented
Jul 9, 2022•

edited

Loading

Copy link


Copy Markdown

Member
@radical
[wasm] Disable tests failing on HighResourceAOT job
63b5ccb
- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this
test for HighResourceAOT
- Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: dotnet#71848
@radicalradical
added
the 
arch-wasm
WebAssembly architecture
label
Jul 9, 2022
@ghostghost
assigned radicalJul 9, 2022
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:-
Labels:
arch-wasm
Milestone:-
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@ghost
ghost
commented
Jul 9, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
  • Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
    
test for HighResourceAOT
  • Also, ensure that the HighResourceAOT tests are run for regular
    
library tests, and EAT.
Issue: #71848
Author:radical
Assignees:radical
Labels:
arch-wasm, area-Infrastructure-libraries
Milestone:-
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
radical
commented
Jul 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
changed the title
[wasm] Disable tests failing on HighResourceAOT job[wasm] Disable tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable tests failing due to linker crash[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radicalradical
changed the title
[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crashJul 9, 2022
@radical
radical
commented
Jul 10, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 10, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radical
Merge remote-tracking branch 'origin/main' into disable-tests-highaot
5d5d572
@radical
[wasm] Disable some STJ.Serialization tests failing due to linker issues
7f4339a
This seems to be hit only with `EnableAggressiveTrimming=true`, and
`RunAOTCompilation=true`. All the traces are similar to:
```
[FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key")
Assert.Throws() Failure
Expected: typeof(System.InvalidOperationException)
Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
----- Inner Stack Trace -----
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken )
at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options)
```
Issue: dotnet#71838
@radicalradical
changed the title
[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issuesJul 11, 2022
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@lewing
lewing
commented
Jul 11, 2022

Copy link


Copy Markdown

Member
cc @agocke
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
Many jobs failing due to #71981 .
I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.
@radical
radical
commented
Jul 11, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 11, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@radicalradical
mentioned this pull request
Jul 12, 2022
 Merged

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
Some of the failures are fixed by #71976 .
And we seem to have new tests failing with the same linker error now:
[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual: typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info: at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-wasm
@azure-pipelines
azure-pipelinesBot
commented
Jul 12, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@runfoapprunfoappBot
mentioned this pull request
Jul 12, 2022

Closed

@radicalradical
mentioned this pull request
Jul 12, 2022

Closed

@radical
radical
commented
Jul 12, 2022

Copy link


Copy Markdown

MemberAuthor
The coreclr failure is #71995 .

The wasm/debugger failure is intermittent.
@radical
radical
merged commit cf83273
into
dotnet:mainJul 12, 2022
@radical
radical
deleted the

disable-tests-highaot

branch
July 12, 2022 06:44
eiriktsarpalis
eiriktsarpalis
reviewed
Jul 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
 var dictionary = new Dictionary<object, object>();
 // Uri is an unsupported dictionary key.
 dictionary.Add(new Uri("http://foo"), "bar");
 dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an accidental change, could you revert please? cc @krwq
@eiriktsarpaliseiriktsarpalisJul 12, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised that this doesn't break other platforms.
@ghostghost
locked as resolved and limited conversation to collaborators
Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@radical@lewing@stephentoub@eiriktsarpalis