Uh oh!
There was an error while loading. Please reload this page.
[QUIC] System.Net.Quic API made public - #72031
Conversation
ghost
commented
Jul 12, 2022
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsSystem.Net.Quic removed from ASP transport package and made part of SDK ref. @ViktorHofer is this enough to revert hiding System.Net.Quic ref and to remove it from ASP.NET transport package? Or am I missing something. Also cc @JamesNK there probably will be follow up on your side. I assume only some clean up in project files.
|
ViktorHofer
commented
Jul 12, 2022
Yes that looks complete. Nit, please also remove the ProjectReference here: (as it's now a default reference via the shared framework). |
| <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences> | ||
| </PropertyGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Don't we need to remove the RequiresPreviewFeaturesAttribute when exposing the assembly in the shared framework?
There was a problem hiding this comment.
I'm not sure I fully understand, but we want to have S.N.Quic as PreviewFeature, since we want to be able to tweak the API for .NET 8. I hope the way I did it is correct.
* System.Net.Quic removed from ASP transport package and made part of SDK ref * Removed manual references to System.Net.Quic.csproj
ManickaP
commented
Jul 13, 2022
@JamesNK and this is the last change which publishes S.N.Quic as part of shared framework (i.e. ref dll) and removes it from ASP transport package. Some project level cleanup will be needed. |
…72031) (#72106) * [QUIC] API QuicConnection (#71783) * Listener comment; PreviewFeature attribute * Feedback * QuicConnection new API including compilable implementation * Fixed logging * Fixed S.N.Quic and S.N.Http tests * Options now correspond to the issue * Feedback * Comments, PreviewFeature attribute and RemoteCertificate disposal. * Preview feature attribute is assembly wide * Some typos * Fixed test with certificate * Default values as constants * Event handlers split into methods called via switch expression. * Some more comments * Unified unsafe usage * Fixed some more tests * Cleaned up some exceptions and resource strings. * Feedback * Latest greatest API proposal. * Fixed Http solution * Feedback * [QUIC] API QuicStream (#71969) * Quic stream API surface * Fixed test compilation * Fixed http test compilation * HttpLoopbackConnection Dispose -> DisposeAsync * QuicStream implementation * Fixed some tests * Fixed all QUIC and HTTP tests * Fixed exception type for stream closed by connection close * Feedback * Fixed WebSocket.Client test build * Feedback, test fixes * Fixed build on framework and windows * Fixed winhandler test * Swap variable based on order in defining class * Post merge fixes * Feedback and build * Reverted connection state to pass around abort error code * Fixed exception type. * [QUIC] System.Net.Quic API made public (#72031) * System.Net.Quic removed from ASP transport package and made part of SDK ref * Removed manual references to System.Net.Quic.csproj
System.Net.Quic removed from ASP transport package and made part of SDK ref.
@ViktorHofer is this enough to revert hiding System.Net.Quic ref and to remove it from ASP.NET transport package? Or am I missing something.
Also cc @JamesNK there probably will be follow up on your side. I assume only some clean up in project files.
cc: @CarnaViire@wfurt@rzikm