Uh oh!
There was an error while loading. Please reload this page.
[mono] Build mono logging profiler on s390x - #72049
Merged
Merged
Conversation
At the moment we don't have too many profiling options on s390x, and the logging profiler comes in handy. Enable building it on s390x and define MONO_DLL_EXPORT in order to unhide mono_profiler_init_log().
steveisok
commented
Jan 23, 2023
Member
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
self-requested a review
January 23, 2023 17:32
steveisok
approved these changes
Jan 23, 2023
crummel
commented
Jan 25, 2023
Contributor
@pavelsavara@lambdageek@vargaz Anything else needed before we merge this? |
vargaz
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment we don't have too many profiling options on s390x, and
the logging profiler comes in handy. Enable building it on s390x and
define MONO_DLL_EXPORT in order to unhide mono_profiler_init_log().