Skip to content

Add TieredPGO and ReadyToRun to Microsoft-Windows-DotNETRuntime/TieredCompilation/Settings event - #72056

Merged
eduardo-vp merged 18 commits into
dotnet:mainfrom
eduardo-vp:feature/add-tieredpgo-readytorun-flags
Aug 4, 2022
Merged

Add TieredPGO and ReadyToRun to Microsoft-Windows-DotNETRuntime/TieredCompilation/Settings event#72056
eduardo-vp merged 18 commits into
dotnet:mainfrom
eduardo-vp:feature/add-tieredpgo-readytorun-flags

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jul 12, 2022

Copy link
Copy Markdown
Member

Fixes#69820

@ghostghost assigned eduardo-vpJul 12, 2022
@ghostghost added the area-VM-coreclr label Jul 12, 2022
@eduardo-vp
eduardo-vp requested a review from kouvelJuly 12, 2022 23:27
kouvel
kouvel reviewed Jul 13, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eventtrace.cpp Outdated
kouvel
kouvel approved these changes Jul 13, 2022
View reviewed changes

@kouvelkouvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise LGTM

Comment threadsrc/coreclr/vm/eventtrace.cpp
jkotas
jkotas requested changes Jul 13, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eeconfig.h
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 13, 2022
@eduardo-vpeduardo-vp mentioned this pull request Jul 13, 2022
Merged
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 14, 2022
@eduardo-vp
eduardo-vp requested a review from jkotasJuly 14, 2022 18:45
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eeconfig.cpp Outdated
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eeconfig.cpp Outdated
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eeconfig.cpp Outdated
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/readytoruninfo.cpp
@eduardo-vp
eduardo-vp marked this pull request as ready for review August 3, 2022 00:05
@eduardo-vp
eduardo-vp requested review from jkotas and kouvelAugust 3, 2022 00:09
@eduardo-vp

eduardo-vp commented Aug 3, 2022

Copy link
Copy Markdown
MemberAuthor

After the previous review, I set the value of ReadyToRun and TieredPGO before the event was fired (a bug of mine) and added a conditional on the ReadyToRun as the TieredPGO has one as well

jkotas
jkotas requested changes Aug 3, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eeconfig.cpp Outdated
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 3, 2022
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 3, 2022
kouvel
kouvel reviewed Aug 3, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/eeconfig.cpp
@eduardo-vp

eduardo-vp commented Aug 4, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Aug 4, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vp merged commit 0c4db6e into dotnet:mainAug 4, 2022
@AndyAyersMSAndyAyersMS mentioned this pull request Aug 9, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
+1 more reviewer
@kouvelkouvelkouvel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eduardo-vpeduardo-vp

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

It is difficult to determine whether TieredPGO and ReadyToRun are enabled

3 participants

@eduardo-vp@jkotas@kouvel