Skip to content

Tar: restore directory permissions while extracting. - #72078

Merged
carlossanlop merged 13 commits into
dotnet:mainfrom
tmds:tar_dir_modes
Aug 12, 2022
Merged

Tar: restore directory permissions while extracting.#72078
carlossanlop merged 13 commits into
dotnet:mainfrom
tmds:tar_dir_modes

Conversation

@tmds

@tmdstmds commented Jul 13, 2022

Copy link
Copy Markdown
Member

Fixes#71140.

@eerhardt@carlossanlop @dotnet/area-system-io ptal.

@ghostghost added area-System.IO community-contribution Indicates that the PR has been added by a community member labels Jul 13, 2022
@ghost

ghost commented Jul 13, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #71140.

@eerhardt@carlossanlop @dotnet/area-system-io ptal.

Author:tmds
Assignees:-
Labels:

area-System.IO

Milestone:-

tmds
tmds commented Jul 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
@carlossanlopcarlossanlop added this to the 7.0.0 milestone Jul 13, 2022
@carlossanlop

carlossanlop commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tmds

tmds commented Jul 13, 2022

Copy link
Copy Markdown
MemberAuthor

@carlossanlop this includes the tests mentioned in #71647 (comment).

I've created the issue for Tar and Zip, this PR only handles Tar.

@runfoapprunfoappBot mentioned this pull request Jul 14, 2022
Closed
eerhardt
eerhardt reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs
eerhardt
eerhardt reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs
eerhardt
eerhardt reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
eerhardt
eerhardt reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
carlossanlop
carlossanlop reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
carlossanlop
carlossanlop reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.ExtractToFile.Tests.cs Outdated
carlossanlop
carlossanlop reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.ExtractToFile.Tests.cs Outdated
carlossanlop
carlossanlop reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.ExtractToFile.Tests.cs Outdated
carlossanlop
carlossanlop reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.ExtractToFile.Tests.cs Outdated
carlossanlop
carlossanlop reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.ExtractToFile.Tests.cs Outdated
This was referenced Jul 14, 2022
Closed
Closed
tmds
tmds commented Jul 29, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Windows.cs Outdated
@tmds@eerhardt
Apply suggestions from code review
67a6023
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
eerhardt
eerhardt reviewed Aug 2, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.File.Base.Windows.cs Outdated
eerhardt
eerhardt approved these changes Aug 2, 2022
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine. It would be good to get sign-off from @carlossanlop.

carlossanlop
carlossanlop reviewed Aug 8, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Windows.cs Outdated
@carlossanlop

carlossanlop commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

I applied the build failure fix, but then I ran the Windows tests and noticed they are failing with these errors:

Details
 Discovering: System.Formats.Tar.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Formats.Tar.Tests (found 476 test cases)
Starting: System.Formats.Tar.Tests (parallel test collections = on, max threads = 12)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: V7, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: V7, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: V7, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: V7, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Ustar, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Ustar, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Ustar, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Ustar, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Pax, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Pax, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Pax, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Pax, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Gnu, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Gnu, createTarget: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(format: Gnu, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(204,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarEntryFo
rmat format, Boolean createTarget)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_Async(format: Gnu, createTarget: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(220,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(223,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(224,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_SymbolicLink_
Async(TarEntryFormat format, Boolean createTarget)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.VerifyIncludeBaseDirectory_Async(includeBaseDirectory: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectoryAsync.File.Tests.cs(130,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.Verif
yIncludeBaseDirectory_Async(Boolean includeBaseDirectory)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectory.File.Tests.cs(108,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBa
seDirectory(Boolean includeBaseDirectory)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(155,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarEntryForma
t format, Boolean withContents)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_Directory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.VerifyIncludeBaseDirectory_Async(includeBaseDirectory: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectoryAsync.File.Tests.cs(123,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectoryAsync_File_Tests.Verif
yIncludeBaseDirectory_Async(Boolean includeBaseDirectory)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: V7) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarTestsBase.cs(405,0): at System.Formats.Tar.Tests.TarTestsBase.AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFileMode fileMode)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarFile\TarFile.CreateFromDirectory.File.Tests.cs(101,0): at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBa
seDirectory(Boolean includeBaseDirectory)
at InvokeStub_TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: Ustar) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: V7) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
mat)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: Pax) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Ustar) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
mat)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Pax) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
mat)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(format: Gnu) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(117,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(120,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(121,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_File_Async(Ta
rEntryFormat format)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntry.File.Tests.cs(109,0): at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat for
mat)
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: V7, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: V7, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Ustar, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Ustar, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Pax, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Pax, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Gnu, withContents: False) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Async(format: Gnu, withContents: True) [FAIL]
Assert.Equal() Failure
Expected: OtherExecute | OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Actual: OtherRead | GroupExecute | GroupRead | UserExecute | UserWrite | UserRead
Stack Trace:
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.File.Base.Windows.cs(16,0): at System.Formats.Tar.Tests.TarWriter_File_Base.VerifyPlatformSpecificMetadata(String filePa
th, TarEntry entry)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(167,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(170,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
D:\runtime\src\libraries\System.Formats.Tar\tests\TarWriter\TarWriter.WriteEntryAsync.File.Tests.cs(171,0): at System.Formats.Tar.Tests.TarWriter_WriteEntryAsync_File_Tests.Add_Directory_Asy
nc(TarEntryFormat format, Boolean withContents)
--- End of stack trace from previous location ---
Finished: System.Formats.Tar.Tests
=== TEST EXECUTION SUMMARY ===
System.Formats.Tar.Tests Total: 755, Errors: 0, Failed: 44, Skipped: 0, Time: 0.736s
----- end 2022-08-08 11:50:38.30 ----- exit code 1 ----------------------------------------------------------

@tmds

tmds commented Aug 8, 2022

Copy link
Copy Markdown
MemberAuthor

I applied the #72078 (comment), but then I ran the Windows tests and noticed they are failing with these errors:

There was a typo in the DefaultWindowsMode. It should be fixed now.

carlossanlop
carlossanlop reviewed Aug 8, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
carlossanlop
carlossanlop reviewed Aug 8, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
carlossanlop
carlossanlop reviewed Aug 8, 2022
View reviewed changes
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.Unix.cs Outdated
@carlossanlop

carlossanlop commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

carlossanlop
carlossanlop reviewed Aug 8, 2022
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmds I left a few more comments and also ran a runtime extra platforms job.

@tmds@carlossanlop
Apply suggestions from code review
956094c
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@carlossanlop

carlossanlop commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 11, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

carlossanlop
carlossanlop approved these changes Aug 11, 2022
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge it assuming the extra platforms CI legs don't show anything weird.

@carlossanlop

carlossanlop commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

Lots of unrelated failures, nothing on tar. Merging :shipit:

Thank you @tmds for your help!

@carlossanlop
carlossanlop merged commit 820ffd4 into dotnet:mainAug 12, 2022
@tmdstmds mentioned this pull request Aug 17, 2022
Merged
@simonrozsivalsimonrozsival mentioned this pull request Aug 17, 2022
Closed
@carlossanlopcarlossanlop mentioned this pull request Sep 8, 2022
Open
@ghostghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardteerhardteerhardt approved these changes
@adamsitnikadamsitnikAwaiting requested review from adamsitnik
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Formats.Tarcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Zip and Tar don't (re)store directory permissions

5 participants

@tmds@carlossanlop@eerhardt@jeffhandley@adamsitnik