Remove an assert from impHWIntrinsic

[EgorBo]

Fixes#72081

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #72081

Author:	EgorBo
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[EgorBo]

hm.. the test I added crashes mono llvmaot https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1877495/logs/1885 cc @fanyang-mono@vargaz any quick fix I can apply or just add it to the ignore list and file an issue?

 * Assertion: should not be reached at /__w/1/s/src/mono/mono/mini/simd-intrinsics.c:627

[vargaz]

UInt128 is probably not allowed as a simd type by mono, so I'd suggest ignoring the test for now.

[EgorBo]

UInt128 is probably not allowed as a simd type by mono, so I'd suggest ignoring the test for now.

From my understanding it's also not supported on CLR, it's expected to throw a not-supported-exception rather than an assert

[EgorBo]

the fix I've just applied seems to work - it also guards from using Vector128<char> which is a quite popular mistake users make 🙂

[tannergooding]

From my understanding it's also not supported on CLR, it's expected to throw a not-supported-exception rather than an assert

Right, Vector128<UInt128> might be declared by a user and so the runtime should robustly handle it. In this case it should at least fallback to the software path which will then throw NotSupportedException since its an unsupported T.

[vargaz]

The mono change looks ok.

[fanyang-mono]

Same check should probably be added to SN_CreateScalar and SN_CreateScalarUnsafe as well.

[fanyang-mono]

Same check should probably be added to SN_CreateScalar and SN_CreateScalarUnsafe as well.

I just checked that CoreCLR doesn't those exceptions for unsupported types when calling the above two methods, then mono doesn't need to do so either. Your fix for mono looks good to me.

[EgorBo]

There were still asserts, turns out I didn't test properly and didn't realize that Vector128.Create has generic and non-generic overloads, now it works OK, I validated Mono-LLVM codegen for:

[MethodImpl(MethodImplOptions.NoInlining)]staticVector128<int>Foo1()=>Vector128.Create(42);// non-generic[MethodImpl(MethodImplOptions.NoInlining)]staticVector128<int>Foo2()=>Vector128.Create<int>(42);// generic[MethodImpl(MethodImplOptions.NoInlining)]staticVector128<char>Foo3()=>Vector128.Create<char>('4');[MethodImpl(MethodImplOptions.NoInlining)]staticVector128<Int128>Foo4()=>Vector128.Create<Int128>(42);

Foo1 and Foo2 emit correct broadcast instructions while Foo3 and Foo4 emit throw new NotSupportedException

[EgorBo]

CI failure is unrelated: #72182