Skip to content

Annotating libraries with small number of warnings to be AOT safe - #72108

Merged
LakshanF merged 3 commits into
dotnet:mainfrom
LakshanF:FixLowLibWarnings
Jul 15, 2022
Merged

Annotating libraries with small number of warnings to be AOT safe#72108
LakshanF merged 3 commits into
dotnet:mainfrom
LakshanF:FixLowLibWarnings

Conversation

@LakshanF

@LakshanFLakshanF commented Jul 13, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Draft PR to check the viability to make these libraries AOT-compatible with minimal effort

@ghost

ghost commented Jul 13, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jul 13, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned LakshanFJul 13, 2022
@LakshanF
LakshanF marked this pull request as draft July 13, 2022 16:40
@LakshanF

LakshanF commented Jul 13, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkotas
jkotas reviewed Jul 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Reflection.DispatchProxy/src/System.Reflection.DispatchProxy.csproj Outdated
jkotas
jkotas reviewed Jul 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/src/System/Data/DataTable.cs Outdated
jkotas
jkotas reviewed Jul 13, 2022
View reviewed changes
Comment threadsrc/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs Outdated
@LakshanF

LakshanF commented Jul 13, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@runfoapprunfoappBot mentioned this pull request Jul 14, 2022
Closed
@LakshanF

LakshanF commented Jul 14, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@LakshanF
LakshanF marked this pull request as ready for review July 14, 2022 16:38
@runfoapprunfoappBot mentioned this pull request Jul 14, 2022
Closed
@LakshanF
LakshanF merged commit 87aa786 into dotnet:mainJul 15, 2022
@LakshanF
LakshanF deleted the FixLowLibWarnings branch July 15, 2022 11:01
@karelzkarelz mentioned this pull request Jul 22, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@LakshanFLakshanF

Labels

area-NativeAOT-coreclrnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LakshanF@jkotas