Skip to content

Enabling 9 new libraries tests for NativeAOT - #72167

Merged
MichalStrehovsky merged 7 commits into
dotnet:mainfrom
MichalStrehovsky:moretests
Jul 15, 2022
Merged

Enabling 9 new libraries tests for NativeAOT#72167
MichalStrehovsky merged 7 commits into
dotnet:mainfrom
MichalStrehovsky:moretests

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Jul 14, 2022

Copy link
Copy Markdown
Member

No description provided.

@MichalStrehovsky

MichalStrehovsky commented Jul 14, 2022

Copy link
Copy Markdown
MemberAuthor

There is one product fix, the rest is just test annotations for single file, trimming, and a couple other things.

One of the tests is a nice forkbomb for single file executables. Shot down my machine. Fun times.

Cc @dotnet/ilc-contrib

@MichalStrehovsky

MichalStrehovsky commented Jul 14, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@EgorBoEgorBo mentioned this pull request Jul 14, 2022
Closed
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Threading.Thread/tests/ThreadTests.cs
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer), nameof(PlatformDetection.IsNotMobile))]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer), nameof(PlatformDetection.IsNotMobile), nameof(PlatformDetection.HasHostExecutable))]

@jkotasjkotasJul 14, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SkipOnPlatform below can be deleted. They are redundant with PlatformDetection.IsNotMobile

jkotas
jkotas approved these changes Jul 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Memory/tests/TestHelpers.cs Outdated
Comment threadsrc/libraries/System.Memory/tests/TestHelpers.cs Outdated
Comment threadsrc/libraries/System.Memory/tests/TestHelpers.cs Outdated
Comment threadsrc/libraries/System.Memory/tests/TestHelpers.cs Outdated
This was referenced Jul 14, 2022
Closed
Closed
MichalStrehovskyand others added 2 commits July 15, 2022 08:27
@MichalStrehovsky
Sigh
61d5044
@MichalStrehovsky@jkotas
Apply suggestions from code review
303fa62
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas reviewed Jul 15, 2022
View reviewed changes
Comment threadsrc/libraries/System.Threading.Thread/tests/ThreadTests.cs Outdated
@MichalStrehovsky

MichalStrehovsky commented Jul 15, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 15, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky

MichalStrehovsky commented Jul 15, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jul 15, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
MichalStrehovsky merged commit c670547 into dotnet:mainJul 15, 2022
@MichalStrehovsky
MichalStrehovsky deleted the moretests branch July 15, 2022 08:36
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky@jkotas