Skip to content

[wasm] add new interop to the console template - #72375

Merged
radekdoulik merged 15 commits into
dotnet:mainfrom
alinpahontu2912:main
Jul 21, 2022
Merged

[wasm] add new interop to the console template#72375
radekdoulik merged 15 commits into
dotnet:mainfrom
alinpahontu2912:main

Conversation

@alinpahontu2912

@alinpahontu2912alinpahontu2912 commented Jul 18, 2022

Copy link
Copy Markdown
Member

First attempt at a working wasm console template

@ghostghost added area-System.Console community-contribution Indicates that the PR has been added by a community member labels Jul 18, 2022
@dnfadmin

dnfadmin commented Jul 18, 2022•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ghost

ghost commented Jul 18, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

First attempt at a working wasm console template

Author:alinpahontu2912
Assignees:-
Labels:

area-System.Console

Milestone:-

@adamsitnikadamsitnik added arch-wasm WebAssembly architecture area-Build-mono and removed area-System.Console labels Jul 18, 2022
@ghost

ghost commented Jul 18, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

First attempt at a working wasm console template

Author:alinpahontu2912
Assignees:-
Labels:

arch-wasm, area-System.Console, community-contribution

Milestone:-

pavelsavara
pavelsavara reviewed Jul 18, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/console.csproj Outdated
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/console.csproj Outdated
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/main.mjs Outdated
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/Program.cs Outdated
radekdoulik
radekdoulik requested changes Jul 18, 2022
View reviewed changes

@radekdoulikradekdoulik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please fix white space in console.0.csproj. Looks like your editor replaced spaces with tabs in that file.

@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 18, 2022
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/Program.cs Outdated
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/Program.cs Outdated
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 18, 2022
@radekdoulikradekdoulik changed the title Wasm console template[wasm] add new interop to the console templateJul 18, 2022
@radical

radical commented Jul 18, 2022

Copy link
Copy Markdown
Member

@alinpahontu2912 could you please merge main to your branch? It has fixes for the build failures here.

@radekdoulik

radekdoulik commented Jul 20, 2022

Copy link
Copy Markdown
Member

Alin is working on fixing the remaining test failure.

radical
radical reviewed Jul 20, 2022
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/main.mjs
@radekdoulik

radekdoulik commented Jul 21, 2022

Copy link
Copy Markdown
Member

The failing builds are unrelated.

@radekdoulik
radekdoulik merged commit 70999d8 into dotnet:mainJul 21, 2022
@yamachuyamachu mentioned this pull request Jul 21, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@radekdoulikradekdoulikradekdoulik approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Build-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alinpahontu2912@dnfadmin@radical@radekdoulik@pavelsavara@adamsitnik