Uh oh!
There was an error while loading. Please reload this page.
Make PhysicalFileProvider polling more resilient to IO exceptions - #72462
Conversation
ghost
commented
Jul 19, 2022
Tagging subscribers to this area: @dotnet/area-extensions-filesystem |
danmoseley
left a comment
There was a problem hiding this comment.
Should we catch any exception that could be IO related? Or is the API we are calling only going to throw these two?
Reasoning: the app has little or no control over whether examining arbitrary files on disk leads to an IO exception. It could be a corrupted disk, for a start. The app can't filter these out and can't catch them - it will just terminate. Is that a better experience than catching them?
If we catch all IO exceptions, you can use this as a guide:
https://github.com/dotnet/msbuild/blob/c34eb484f1ddf0f9e1940c620b1eff169433f5a1/src/Shared/ExceptionHandling.cs#L130-L145
jozkee
commented
Jul 19, 2022
I'm certain the API won't throw these ones: eisNotSupportedException||(eisArgumentException&&!(eisArgumentNullException))||eis SecurityExceptionAll exceptions come form |
danmoseley
commented
Jul 19, 2022
sounds good to me. |
jozkee
commented
Jul 19, 2022
One CI error is #70969, the other one is System.Net.Http test failures (couldn't find a related issue). |
Fixes#71003
Fixes#56810