Skip to content

Assert compiler diagnostics in UpgradeToRegexGeneratorAnalyzerTests and simplify tests - #72580

Merged
joperezr merged 2 commits into
dotnet:mainfrom
Youssef1313:improve-regex-gen-testing
Jul 21, 2022
Merged

Assert compiler diagnostics in UpgradeToRegexGeneratorAnalyzerTests and simplify tests#72580
joperezr merged 2 commits into
dotnet:mainfrom
Youssef1313:improve-regex-gen-testing

Conversation

@Youssef1313

@Youssef1313Youssef1313 commented Jul 21, 2022

Copy link
Copy Markdown
Member

Fixes#72544

@ghostghost added area-System.Text.RegularExpressions community-contribution Indicates that the PR has been added by a community member labels Jul 21, 2022
@ghost

ghost commented Jul 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #72544

Author:Youssef1313
Assignees:-
Labels:

area-System.Text.RegularExpressions

Milestone:-

@Youssef1313Youssef1313 changed the title Assert compiler diagnostics in UpgradeToRegexGeneratorAnalyzerTestsAssert compiler diagnostics in UpgradeToRegexGeneratorAnalyzerTests and simplify testsJul 21, 2022
@Youssef1313

Youssef1313 commented Jul 21, 2022

Copy link
Copy Markdown
MemberAuthor

@joperezr Can you take a look please? Thanks!

@joperezr

joperezr commented Jul 21, 2022

Copy link
Copy Markdown
Member

Merging since failures are unrelated. Thanks @Youssef1313!

@joperezr
joperezr merged commit 5044106 into dotnet:mainJul 21, 2022
@Youssef1313
Youssef1313 deleted the improve-regex-gen-testing branch July 21, 2022 18:34
@ghostghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezrjoperezrjoperezr approved these changes

Assignees

No one assigned

Labels

area-System.Text.RegularExpressionscommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad test input in UpgradeToRegexGeneratorAnalyzerTests

2 participants

@Youssef1313@joperezr