Skip to content

Allow not finding attribute data for more cases that we don't care about - #72620

Merged
jkoritzinsky merged 2 commits into
mainfrom
jkoritzinsky-patch-1
Jul 21, 2022
Merged

Allow not finding attribute data for more cases that we don't care about#72620
jkoritzinsky merged 2 commits into
mainfrom
jkoritzinsky-patch-1

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Jul 21, 2022

Copy link
Copy Markdown
Member

This will fix the upstream repo intake of dotnet/runtime by allowing us to fall back to null for cases where Roslyn does things that we aren't expecting with the "ContainingSymbol" value.

Fixes#72622

This will fix the upstream repo intake of dotnet/runtime by allowing us to fall back to null for cases where Roslyn does things that we aren't expecting with the "ContainingSymbol" value.
@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jul 21, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This will fix the upstream repo intake of dotnet/runtime by allowing us to fall back to null for cases where Roslyn does things that we aren't expecting with the "ContainingSymbol" value.

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:-

@jkoritzinsky

Copy link
Copy Markdown
MemberAuthor

Test failures are unrelated

@jkoritzinsky
jkoritzinsky merged commit 24f3234 into mainJul 21, 2022
@jkoritzinsky
jkoritzinsky deleted the jkoritzinsky-patch-1 branch July 21, 2022 20:38
@ghostghost locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MarshallingAttributeAnalyzers throws InvalidOperationException

3 participants

@jkoritzinsky@AaronRobinsonMSFT@elinor-fung