Skip to content

Add stateful marshaller support to the CustomMarshallerAttributeAnalyzer - #72888

Merged
jkoritzinsky merged 6 commits into
dotnet:mainfrom
jkoritzinsky:stateful-shape-analyzer
Jul 29, 2022
Merged

Add stateful marshaller support to the CustomMarshallerAttributeAnalyzer#72888
jkoritzinsky merged 6 commits into
dotnet:mainfrom
jkoritzinsky:stateful-shape-analyzer

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Jul 26, 2022

Copy link
Copy Markdown
Member

Add support and tests for analyzing the required shapes for stateful marshallers.

@jkoritzinsky
Add stateful marshaller support to the CustomMarshallerAttributeAnalyzer
251802e
Add support and tests for analyzing the required shapes for stateful marshallers.
@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jul 26, 2022
@jkoritzinskyjkoritzinsky added this to the 7.0.0 milestone Jul 26, 2022
@ghost

ghost commented Jul 26, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Add support and tests for analyzing the required shapes for stateful marshallers.

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:7.0.0

elinor-fung
elinor-fung approved these changes Jul 28, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx Outdated
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx Outdated
Comment thread...me.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs Outdated
Comment thread...portGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs
@jkoritzinsky
jkoritzinskyforce-pushed the stateful-shape-analyzer branch from 0888e2f to 4241d41CompareJuly 28, 2022 20:50
@jkoritzinsky
jkoritzinsky merged commit a01aea9 into dotnet:mainJul 29, 2022
@jkoritzinsky
jkoritzinsky deleted the stateful-shape-analyzer branch July 29, 2022 21:21
@danmoseleydanmoseley mentioned this pull request Jul 31, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@elinor-fungelinor-fungelinor-fung approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFT

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jkoritzinsky@elinor-fung